chore(ui): fix eslint errors in composed and profile modules#9242
Conversation
PR #9144 landed on main with ESLint errors (unsorted imports, missing curly braces, unused imports, an empty catch) that turbo's lint cache masked on the main push. Any PR that misses the cache re-runs lint and fails static analysis on these. Autofix + one manual empty-catch comment.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d57c6fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
📝 WalkthroughWalkthroughThis pull request applies UI lint and TypeScript cleanup across security components, composed sections, hooks, mosaic conditions, and tests. It reformats existing early-return guards, reorders imports, removes unnecessary type assertions and unused imports, simplifies timer cleanup calls, clarifies relative-route handling, updates test spies, and adds a changeset. No exported APIs or component behavior are changed. Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Warning Review ran into problems🔥 ProblemsLinked repositories: Couldn't analyze
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260724T143133.829295115.log'. Errors logged to '/home/jailuser/git/.git/lfs/logs/20260724T143253.766924725.log'. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/ui/src/components/ConfigureSSO/domain/__tests__/organizationEnterpriseConnection.test.ts`:
- Line 291: Update the makeUser test helper to construct a valid UserResource
fixture rather than casting or returning Partial<UserResource> directly. Define
complete base UserResource values, merge the provided overrides into them, and
preserve the existing call sites’ ability to customize fixture fields.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 81ec6f08-c218-4120-a1dd-d8721f935c5a
📒 Files selected for processing (14)
.changeset/fix-ui-lint.mdpackages/ui/src/components/ConfigureSSO/domain/__tests__/organizationEnterpriseConnection.test.tspackages/ui/src/components/UserProfile/SecurityPage.tsxpackages/ui/src/components/UserProfile/SecuritySections.tsxpackages/ui/src/components/UserProfile/__tests__/ConnectedAccountsSection.test.tsxpackages/ui/src/components/UserProfile/__tests__/SecuritySections.test.tsxpackages/ui/src/composed/APIKeysSection.tsxpackages/ui/src/composed/BillingSection.tsxpackages/ui/src/composed/__tests__/OrganizationProfile.test.tsxpackages/ui/src/composed/__tests__/stub-limitations.test.tspackages/ui/src/composed/createSection.tsxpackages/ui/src/composed/useBillingRouter.tspackages/ui/src/hooks/useWarnAboutCustomizationWithoutPinning.tspackages/ui/src/mosaic/conditions.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
clerk/clerk_go(manual)clerk/dashboard(manual)clerk/accounts(manual)clerk/backoffice(manual)clerk/clerk(manual)clerk/clerk-docs(manual)clerk/cloudflare-workers(manual)clerk/cli(auto-detected)clerk/clerk-ios(auto-detected)clerk/clerk-android(auto-detected)
2 participants
Description
PR #9144 (
feat(ui): Expose composed profile components) landed onmainwith ESLint errors that were masked by turbo's lint cache on the main push. Any PR whose lint task misses the cache re-runseslintand fails Static analysis → @clerk/ui#lint on these pre-existing errors (I hit this on #9241).Errors fixed (all in files from #9144):
simple-import-sort/imports— unsorted importscurly— missing braces on single-lineifno-unused-vars/unused-imports— unused importsno-empty— emptycatchinuseBillingRouter.ts(added a why-comment; the swallow is intentional for relative-URL fallthrough)All but the empty-catch were resolved with
eslint --fix; autofixed warnings in the touched package are included too.Verification
pnpm --filter @clerk/ui lint→ exit 0pnpm --filter @clerk/ui type-check→ cleancomposed+UserProfiletests → 74 passedChangeset
Empty — no user-facing change (import order, braces, unused-import removal, a comment).