Skip to content

fix(ui): provide CardState to composed OrganizationProfileGeneralPanel default page#9243

Merged
alexcarpenter merged 1 commit into
mainfrom
fix/org-general-panel-cardstate
Jul 24, 2026
Merged

fix(ui): provide CardState to composed OrganizationProfileGeneralPanel default page#9243
alexcarpenter merged 1 commit into
mainfrom
fix/org-general-panel-cardstate

Conversation

@alexcarpenter

Copy link
Copy Markdown
Member

Description

The composed OrganizationProfileGeneralPanel (exported from @clerk/ui/experimental) threw CardState not found when a consumer used it in its default, no-children page mode and then clicked Leave organization or Delete organization:

<OrganizationProfileProvider>
  <OrganizationProfileGeneralPanel />
</OrganizationProfileProvider>

Root cause

OrganizationGeneralPage does not self-wrap in a CardStateProvider (unlike AccountPage / SecurityPage, which use withCardStateProvider). In the mounted <OrganizationProfile />, the missing provider is supplied by the single root withCardStateProvider at the component root (OrganizationProfile/index.tsx). The leave/delete confirmation forms call useCardState() at the form level (useLeaveWithRevalidations, ActionConfirmationPage.tsx:21) — outside ActionConfirmationPage's own self-wrap — so they rely on that root provider.

The composed panel is a standalone entry point and did not reproduce that root, so the form-level useCardState() had no ancestor provider and threw.

Fix

Wrap the no-children branch of OrganizationProfileGeneralPanel in a CardStateProvider, mirroring what the mounted <OrganizationProfile /> provides at its root (and what the composed Security panel already does). The nesting with ActionConfirmationPage's own provider is identical to production behavior today and is harmless — each provider scopes its own subtree.

Checklist

  • Unit test added reproducing the throw and asserting the leave-organization confirmation opens
  • @clerk/ui patch changeset
  • Scope limited to the one affected page; audited the other 8 composed panels (Account/Security self-wrap; billing pages either self-wrap or use no card state)

Type of change

  • 🐛 Bug fix

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jul 24, 2026 4:54pm
swingset Ready Ready Preview, Comment Jul 24, 2026 4:54pm

Request Review

@changeset-bot

changeset-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8208180

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jul 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9243

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9243

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9243

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9243

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9243

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9243

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9243

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9243

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9243

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9243

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9243

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9243

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9243

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9243

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9243

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9243

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9243

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9243

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9243

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9243

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9243

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9243

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9243

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9243

commit: 8208180

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-24T16:55:44.918Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 8208180.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: cb2fb175-d21f-47da-95bc-7696301e9d97

📥 Commits

Reviewing files that changed from the base of the PR and between 2466247 and 8208180.

📒 Files selected for processing (3)
  • .changeset/org-general-panel-cardstate.md
  • packages/ui/src/composed/OrganizationProfile/General.tsx
  • packages/ui/src/composed/__tests__/OrganizationProfileSections.test.tsx
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)
  • clerk/clerk-docs (manual)
  • clerk/cloudflare-workers (manual)
  • clerk/cli (auto-detected)
  • clerk/clerk-ios (auto-detected)
  • clerk/clerk-android (auto-detected)

📝 Walkthrough

Walkthrough

OrganizationProfileGeneralPanel now wraps its default no-children OrganizationGeneralPage render with CardStateProvider, enabling leave- and delete-organization confirmation forms to access CardState. A regression test verifies that the leave confirmation opens, and a changeset records the patch release.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • clerk/javascript#9144: Updates the same composed panel to ensure CardStateProvider is available for confirmation flows.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main fix: supplying CardState to the default OrganizationProfileGeneralPanel page.
Description check ✅ Passed The description directly matches the changeset and explains the bug, root cause, and fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Linked repositories: Couldn't analyze clerk/clerk-android - clone failed: Clone operation failed: Cloning into '/home/jailuser/git'...
warning: templates not found in /usr/share/git-core/templates
From https://github.com/clerk/clerk-android

Errors logged to '/home/jailuser/git/.git/lfs/logs/20260724T165605.503175719.log'.
Use git lfs logs last to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: config/bin/detekt-cli: smudge filter lfs failed
Downloading config/bin/detekt-cli (71 MB)
Error downloading object: config/bin/detekt-cli (2655f48): Smudge error: Error downloading config/bin/detekt-cli (2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1): LFS: Client error: https://github-cloud.githubusercontent.com/alambic/media/877189286/26/55/2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIA5BA2674WPWWEFGQ5%2F20260724%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20260724T165726Z&X-Amz-Expires=3600&X-Amz-Signature=6f8ebc4a71c6f0075dd3e408a3498c5a8c16d6bba71b09f83ea857fac6ef26aa&X-Amz-SignedHeaders=host&actor_id=136622811&key_id=0&repo_id=980409545&token=1

Errors logged to '/home/jailuser/git/.git/lfs/logs/20260724T165726.944916596.log'.
Use git lfs logs last to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: config/bin/detekt-cli: smudge filter lfs failed


Comment @coderabbitai help to get the list of available commands.

@alexcarpenter
alexcarpenter merged commit 41c323a into main Jul 24, 2026
51 checks passed
@alexcarpenter
alexcarpenter deleted the fix/org-general-panel-cardstate branch July 24, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants