docs(backend): Correct Dashboard labels in instance restrictions - #9253
Conversation
…mailDomains The bolded label read "Block sign-ups that use disposable email domains", but the toggle in the Clerk Dashboard is "Block sign-ups that use disposable email addresses". Property names are unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 1bf6b4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
No "Ignore dots for Gmail addresses" toggle exists in the Clerk Dashboard — the setting appears only in the generated DAPI spec, and the backend strips Gmail dots unconditionally. Bold marks a Dashboard label, so this drops it and matches the wording already used on UpdateRestrictionsParams. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughUpdated instance restriction documentation to describe disposable email addresses and aligned related Dashboard label text. Added a patch changeset for Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Description
Two TSDoc comments on the instance restrictions types bold Dashboard labels that don't match the Dashboard. Bold in these comments means "this is the name you'll see in the Dashboard," so a wrong one sends people looking for a control that isn't there.
blockDisposableEmailDomainsreads Block sign-ups that use disposable email domains. The actual toggle is Block sign-ups that use disposable email addresses. Corrected in both places it appears.ignoreDotsForGmailAddressesreads Ignore dots for Gmail addresses, but there's no such toggle. The Restrictions page renders four controls — restricted mode, allowlist/blocklist on sign-ins, block email subaddresses, and block disposable email addresses — and the setting appears only in the generated DAPI spec. The backend strips Gmail dots unconditionally inCanonical(). So there's nothing to name, and the bold comes off.UpdateRestrictionsParamsalready described the same field unbolded and lowercase, so the two now agree.Property names are unchanged.
blockDisposableEmailDomainsis right — the check really is domain-based, matching the address's domain against a disposable-domain list. Only the human-facing labels were wrong.Found while reviewing clerk/clerk#3034, which touches the docs page these comments link to. The linked anchors are unchanged and still resolve.
Worth flagging for whoever picks this up: "addresses" (Dashboard, docs, pricing table) versus "domains" (these properties, the BAPI field) is a naming split that runs wider than these lines. This fixes what's provably wrong against the Dashboard and leaves the split alone.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change