Skip to content

fix(*): resolve appearance against the Ui appearance type instead of Ui - #9281

Merged
brkalow merged 1 commit into
clerk:mainfrom
BobbyLin23:fix/appearance-ui-generic
Jul 30, 2026
Merged

fix(*): resolve appearance against the Ui appearance type instead of Ui#9281
brkalow merged 1 commit into
clerk:mainfrom
BobbyLin23:fix/appearance-ui-generic

Conversation

@BobbyLin23

Copy link
Copy Markdown
Contributor

Appearance<T> is generic over the theme type, but @clerk/vue and @clerk/astro passed the Ui type into it. That resolved to Ui & GlobalAppearanceOptions & { signIn?: Ui, ... }, which has none of theme, variables, elements or options, so every appearance object was rejected. @clerk/nuxt inherits this via PluginOptions.

Use ExtractAppearanceType<TUi, Appearance>, as @clerk/react already does.

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

`Appearance<T>` is generic over the theme type, but `@clerk/vue` and
`@clerk/astro` passed the `Ui` type into it. That resolved to
`Ui & GlobalAppearanceOptions & { signIn?: Ui, ... }`, which has none of
`theme`, `variables`, `elements` or `options`, so every appearance object
was rejected. `@clerk/nuxt` inherits this via `PluginOptions`.

Use `ExtractAppearanceType<TUi, Appearance>`, as `@clerk/react` already does.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e1e0911

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/astro Patch
@clerk/vue Patch
@clerk/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

@BobbyLin7 is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 03c2932f-2944-4041-9a54-5cdffd435f0a

📥 Commits

Reviewing files that changed from the base of the PR and between 3c22061 and e1e0911.

📒 Files selected for processing (4)
  • .changeset/tame-donuts-shake.md
  • packages/astro/src/types.ts
  • packages/vue/src/plugin.ts
  • packages/vue/src/utils/updateClerkOptions.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)
  • clerk/clerk-docs (manual)
  • clerk/cloudflare-workers (manual)

📝 Walkthrough

Walkthrough

Updated Astro and Vue public option typings to derive appearance through ExtractAppearanceType from @clerk/ui/internal, allowing valid appearance properties such as theme, variables, and elements. The Vue option update utility uses the same type without runtime changes. A changeset records patch releases for Astro and Vue and documents the related Nuxt typing effect.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: jeremy-clerk

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing appearance typing to use the Ui-derived appearance type.
Description check ✅ Passed The description matches the changeset and accurately explains the appearance type fix across Vue, Astro, and Nuxt.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alexcarpenter
alexcarpenter requested a review from wobsoriano July 30, 2026 15:29

@wobsoriano wobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome catch, thanks!

@pkg-pr-new

pkg-pr-new Bot commented Jul 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9281

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9281

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9281

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9281

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9281

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9281

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9281

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9281

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9281

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9281

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9281

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9281

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9281

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9281

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9281

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9281

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9281

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9281

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9281

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9281

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9281

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9281

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9281

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9281

commit: e1e0911

@brkalow brkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@brkalow
brkalow merged commit 850051d into clerk:main Jul 30, 2026
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants