Skip to content

fix(clerk-js): Improve error message during Organization invitation - #1781

Merged
panteliselef merged 1 commit into
mainfrom
ORG-88
Sep 28, 2023
Merged

fix(clerk-js): Improve error message during Organization invitation#1781
panteliselef merged 1 commit into
mainfrom
ORG-88

Conversation

@panteliselef

Copy link
Copy Markdown
Contributor

Description

This PR improves the localized message and also the implementation of the constructed message.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@panteliselef
panteliselef requested a review from a team as a code owner September 26, 2023 08:36
@panteliselef panteliselef self-assigned this Sep 26, 2023
@changeset-bot

changeset-bot Bot commented Sep 26, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e8320a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chanioxaris chanioxaris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though we improve the user feedback for this case, i am afraid this won't scale while our APIs will return additional error codes for more cases (e.g. email address exists in the blocklist). We have to think another way to fix that , probably a breaking one in order to fix this once and for all

@panteliselef

Copy link
Copy Markdown
Contributor Author

As this is not breaking change, and enhances the current feedback we provide, I'll proceed with merging. We will continue discussing internally for a better solution that scales for many localized errors per FAPI endpoint

@panteliselef
panteliselef added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit cc88517 Sep 28, 2023
@panteliselef
panteliselef deleted the ORG-88 branch September 28, 2023 12:35
@clerk-cookie clerk-cookie mentioned this pull request Sep 28, 2023
@clerk-cookie

Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants