Skip to content

fix(clerk-js): Correctly set idle card state on add mfa error - #1825

Merged
desiprisg merged 1 commit into
mainfrom
george/usr-365-unresponsive-ui-when-trying-to-set-phone-number-as-2fa
Oct 9, 2023
Merged

fix(clerk-js): Correctly set idle card state on add mfa error#1825
desiprisg merged 1 commit into
mainfrom
george/usr-365-unresponsive-ui-when-trying-to-set-phone-number-as-2fa

Conversation

@desiprisg

Copy link
Copy Markdown
Contributor

Description

Set the card to the idle state after success or error.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@desiprisg
desiprisg requested a review from a team as a code owner October 4, 2023 11:31
@changeset-bot

changeset-bot Bot commented Oct 4, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bbcd9d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@desiprisg
desiprisg added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 5a3995b Oct 9, 2023
@desiprisg
desiprisg deleted the george/usr-365-unresponsive-ui-when-trying-to-set-phone-number-as-2fa branch October 9, 2023 13:58
@clerk-cookie clerk-cookie mentioned this pull request Oct 9, 2023
@clerk-cookie

Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants