Skip to content

fix(clerk-js): Correctly navigate to the continue route if needed during verification - #1870

Merged
desiprisg merged 1 commit into
mainfrom
george/usr-399-editing-phone-number-during-sign-up
Oct 16, 2023
Merged

fix(clerk-js): Correctly navigate to the continue route if needed during verification#1870
desiprisg merged 1 commit into
mainfrom
george/usr-399-editing-phone-number-during-sign-up

Conversation

@desiprisg

@desiprisg desiprisg commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

Description

By adding these two new routes, we can navigate back to the continue step when needed, instead of going back to the start of the sign up flow.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@desiprisg
desiprisg requested a review from a team as a code owner October 12, 2023 10:04
@changeset-bot

changeset-bot Bot commented Oct 12, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f2ca91c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@desiprisg desiprisg changed the title fix(clerk-js): Navigate to when editing the phone number in the continue step fix(clerk-js): Navigate to the continue route when editing the phone number in the verify step Oct 12, 2023
@desiprisg desiprisg changed the title fix(clerk-js): Navigate to the continue route when editing the phone number in the verify step fix(clerk-js): Correctly navigate to the continue route if needed during verification Oct 12, 2023
@desiprisg
desiprisg requested a review from gkats October 12, 2023 10:09

@panteliselef panteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Comment thread packages/clerk-js/src/ui/components/SignUp/SignUp.tsx Outdated
@desiprisg
desiprisg force-pushed the george/usr-399-editing-phone-number-during-sign-up branch from 623b914 to f2ca91c Compare October 13, 2023 09:43
@desiprisg
desiprisg added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit 81b63e3 Oct 16, 2023
@desiprisg
desiprisg deleted the george/usr-399-editing-phone-number-during-sign-up branch October 16, 2023 14:40
@clerk-cookie clerk-cookie mentioned this pull request Oct 16, 2023
@clerk-cookie

Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants