Drop serde_json arbitrary_precision from workspace#5001
Open
clockwork-labs-bot wants to merge 4 commits into
Open
Drop serde_json arbitrary_precision from workspace#5001clockwork-labs-bot wants to merge 4 commits into
clockwork-labs-bot wants to merge 4 commits into
Conversation
Contributor
|
I'm marking this as an API break because it does, technically, change user-visible behavior of using our library as a dependency. We should still do it (assuming CI shows that we are indeed not depending on this behavior), but it bears a release note. |
bfops
previously approved these changes
May 13, 2026
Contributor
bfops
left a comment
There was a problem hiding this comment.
It passes CI so I'm approving
I was looking at the wrong PR.. waiting for CI to actually pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4989
We were not using
arbitrary_precisionin the workspace: I only found the workspace dependency declaration itself plus a normalserde_json::Number::from(3u8)call incrates/cli/src/spacetime_config.rs, which does not require the feature.Summary
serde_json/arbitrary_precisionfrom the workspace dependency declarationraw_value, which is the only serde_json feature the workspace is clearly using hereValidation
cargo tree -e features -p serde_jsoncargo check -p spacetimedb-sdk -p spacetimedb-lib -p spacetimedb-sats -p spacetimedb-schema