Skip to content

Drop serde_json arbitrary_precision from workspace#5001

Open
clockwork-labs-bot wants to merge 4 commits into
masterfrom
bot/fix-4989-drop-arbitrary-precision
Open

Drop serde_json arbitrary_precision from workspace#5001
clockwork-labs-bot wants to merge 4 commits into
masterfrom
bot/fix-4989-drop-arbitrary-precision

Conversation

@clockwork-labs-bot
Copy link
Copy Markdown
Contributor

@clockwork-labs-bot clockwork-labs-bot commented May 12, 2026

Closes #4989

We were not using arbitrary_precision in the workspace: I only found the workspace dependency declaration itself plus a normal serde_json::Number::from(3u8) call in crates/cli/src/spacetime_config.rs, which does not require the feature.

Summary

  • remove serde_json/arbitrary_precision from the workspace dependency declaration
  • keep raw_value, which is the only serde_json feature the workspace is clearly using here
  • avoid forcing a non-additive serde_json feature onto downstream consumers via feature unification

Validation

  • cargo tree -e features -p serde_json
  • cargo check -p spacetimedb-sdk -p spacetimedb-lib -p spacetimedb-sats -p spacetimedb-schema

@gefjon gefjon added breaks library compatibility This change breaks the SpacetimeDB library interface api-break A PR that makes an API breaking change labels May 12, 2026
@gefjon
Copy link
Copy Markdown
Contributor

gefjon commented May 12, 2026

I'm marking this as an API break because it does, technically, change user-visible behavior of using our library as a dependency. We should still do it (assuming CI shows that we are indeed not depending on this behavior), but it bears a release note.

bfops
bfops previously approved these changes May 13, 2026
Copy link
Copy Markdown
Contributor

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes CI so I'm approving

@bfops bfops dismissed their stale review May 13, 2026 03:15

I was looking at the wrong PR.. waiting for CI to actually pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-break A PR that makes an API breaking change breaks library compatibility This change breaks the SpacetimeDB library interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

serde_json/arbitrary_precision in workspace deps breaks downstream serde-derived deserializers

3 participants