Revisión proceso de pruebas y CI por DAAS_B #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implementation of testGetInstance
Los tests de release y reusables
Añadido try catch
There was a problem hiding this comment.
PR Overview
Esta pull request introduce mejoras en el proceso de pruebas y la integración continua.
- Se agregan badges y se actualiza el contenido de estudiantes en el README.
- Se amplían y refinan las pruebas unitarias en ReusablePoolTest.java para cubrir la funcionalidad de adquisión y liberación de instancias.
- Se actualiza la configuración de Codecov en el workflow de GitHub Actions.
Reviewed Changes
| File | Description |
|---|---|
| README.md | Se añaden badges y se actualiza la lista de estudiantes. |
| src/test/java/ubu/gii/dass/c01/ReusablePoolTest.java | Se agregan nuevas pruebas y se actualizan los métodos de prueba para mejorar la cobertura y validar casos límite en el manejo del pool. |
| .github/workflows/Java17CImaven.yml | Se actualiza la acción de Codecov a la versión v5.4.0 y se añade slug para identificar el repositorio. |
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/test/java/ubu/gii/dass/c01/ReusablePoolTest.java:148
- [nitpick] The variable name 'reciclado' is in Spanish while other identifiers are in English. Consider renaming it to 'recycled' for consistency across the codebase.
Reusable reciclado = pool.acquireReusable();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.