add x-stream-offset header to StreamReader responses#1774
Merged
kickster97 merged 3 commits intomainfrom Mar 11, 2026
Merged
Conversation
|
No issues found. The implementation correctly mirrors the existing offset-header pattern used in |
|
Code review: No issues found. The changes are minimal and correct:
|
viktorerlingsson
approved these changes
Mar 9, 2026
snichme
requested changes
Mar 10, 2026
Member
snichme
left a comment
There was a problem hiding this comment.
The read method is currently only used by the stream reader, I don't think it's a good design to add offset as an additional parameter to that method, it's somethign that can be handled outside the method.
snichme
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
After stream offsets were removed from disk storage(#1479), the
x-stream-offsetheader is added dynamically at read time. Theshift?()path handles this correctly, but theread()path (used byStreamReaderfor the/api/queues/:vhost/:name/streamendpoint) was missed.Fixes #1773
This PR adds an offset parameter to
StreamMessageStore#read()and updatesStreamReader#eachto track and pass the offset through, so the header is added consistently across both code paths.HOW can this pull request be tested?
Run the added apec