Skip to content

fix: remove secret check from conditional expressions#318

Merged
clouddrove-ci merged 1 commit intoclouddrove:masterfrom
anmolnagpal:fix/remove-secret-check-from-conditions
Feb 14, 2026
Merged

fix: remove secret check from conditional expressions#318
clouddrove-ci merged 1 commit intoclouddrove:masterfrom
anmolnagpal:fix/remove-secret-check-from-conditions

Conversation

@anmolnagpal
Copy link
Copy Markdown
Collaborator

Cannot check if secrets are empty in reusable workflow conditionals. This causes 'Unrecognized named-value: secrets' parsing error.

The provider check alone is sufficient - if Azure is the provider, the step will run. If AZURE_CREDENTIALS is not provided, the azure/login action will fail appropriately with a clear error message.

Fixes parsing errors:

  • Line 156: inputs.provider == 'azurerm' && secrets.AZURE_CREDENTIALS != ''
  • Line 228: inputs.provider == 'azurerm' && secrets.AZURE_CREDENTIALS != ''

Description

Type of Change

  • 🐛 Bug fix
  • ✨ New workflow
  • 📝 Documentation update
  • 🔧 Workflow enhancement
  • 🎨 Code style/formatting
  • ♻️ Refactoring
  • ⚡ Performance improvement
  • 🔒 Security improvement

Workflow Category

  • Terraform (tf-*)
  • CloudFormation (cf-*)
  • Docker (docker-*)
  • Helm (helm-*)
  • PR Automation (pr-*)
  • Security (security-*)
  • Release (release-*)
  • Notification (notify-*)
  • AWS-specific (aws-*)
  • GCP-specific (gcp-*)
  • YAML Lint (yl-*)
  • Other

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Testing

Screenshots/Documentation

Related Issues

Closes #

Additional Notes

Cannot check if secrets are empty in reusable workflow conditionals.
This causes 'Unrecognized named-value: secrets' parsing error.

The provider check alone is sufficient - if Azure is the provider,
the step will run. If AZURE_CREDENTIALS is not provided, the azure/login
action will fail appropriately with a clear error message.

Fixes parsing errors:
- Line 156: inputs.provider == 'azurerm' && secrets.AZURE_CREDENTIALS != ''
- Line 228: inputs.provider == 'azurerm' && secrets.AZURE_CREDENTIALS != ''
@anmolnagpal anmolnagpal requested review from a team and clouddrove-ci as code owners February 14, 2026 22:24
@clouddrove-ci clouddrove-ci merged commit 521761c into clouddrove:master Feb 14, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants