Skip to content

fix: resolve conventional commit validation issue and skip label requirement for forked PRs#331

Merged
clouddrove-ci merged 1 commit intoclouddrove:masterfrom
anket-cd:fix/commit-validation
Mar 5, 2026
Merged

fix: resolve conventional commit validation issue and skip label requirement for forked PRs#331
clouddrove-ci merged 1 commit intoclouddrove:masterfrom
anket-cd:fix/commit-validation

Conversation

@anket-cd
Copy link
Copy Markdown
Contributor

@anket-cd anket-cd commented Mar 5, 2026

Description

Type of Change

  • 🐛 Bug fix
  • ✨ New workflow
  • 📝 Documentation update
  • 🔧 Workflow enhancement
  • 🎨 Code style/formatting
  • ♻️ Refactoring
  • ⚡ Performance improvement
  • 🔒 Security improvement

Workflow Category

  • Terraform (tf-*)
  • CloudFormation (cf-*)
  • Docker (docker-*)
  • Helm (helm-*)
  • PR Automation (pr-*)
  • Security (security-*)
  • Release (release-*)
  • Notification (notify-*)
  • AWS-specific (aws-*)
  • GCP-specific (gcp-*)
  • YAML Lint (yl-*)
  • Other

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Testing

I tested this on my personal GitHub account for both success and failure cases.
Or slightly better for a PR description:

Screenshots/Documentation

  • Success
Screenshot 2026-03-05 at 11 27 17 PM
  • Failed
Screenshot 2026-03-05 at 5 30 44 PM

Additional Notes

Functionalities Added in Your PR Validation Workflow

  • Run the label check only for internal PRs, not forks.
    What happens now
PR Type Label Validation
Internal PR ✅ checked
Fork PR ⏭ skipped

But commit + PR title validation will still run.
Example flow

Internal contributor
PR → validation runs:

PR title      ✔
commits       ✔
labels        ✔

Fork contributor
PR → validation runs:

PR title      ✔
commits       ✔
labels        ⏭ skipped

@anket-cd anket-cd requested review from a team, anmolnagpal and clouddrove-ci as code owners March 5, 2026 19:05
@anket-cd anket-cd requested a review from archit-cd March 5, 2026 19:05
Copy link
Copy Markdown
Member

@pendharevaibhav-cd pendharevaibhav-cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clouddrove-ci clouddrove-ci merged commit 1a77be9 into clouddrove:master Mar 5, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants