Use TranscodingStream for converting to UTF-8#342
Open
erwinkramer wants to merge 1 commit intocloudevents:mainfrom
Open
Use TranscodingStream for converting to UTF-8#342erwinkramer wants to merge 1 commit intocloudevents:mainfrom
TranscodingStream for converting to UTF-8#342erwinkramer wants to merge 1 commit intocloudevents:mainfrom
Conversation
Contributor
|
This feels like it's reasonable - it's entirely an implementation detail, so a simple |
Signed-off-by: Erwin <erwinkramer@hotmail.com>
erwinkramer
force-pushed
the
feature/transcodingstream
branch
from
54c9d75 to
9326f9e
Compare
Contributor
Author
|
@jskeet sure, I made it conditional now. Should be good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leverages
CreateTranscodingStreamto change the encoding to UTF-8 when required. Because this only exists on .NET 5 and up, I made it conditional and kept the old logic for lower .NET versions.