fix: refresh props for existing Durable Objects via serveSSE POST endpoint#337
Closed
asghar-mir wants to merge 2 commits into
Closed
fix: refresh props for existing Durable Objects via serveSSE POST endpoint#337asghar-mir wants to merge 2 commits into
asghar-mir wants to merge 2 commits into
Conversation
|
Contributor
|
we landed this one instead, would it work for you? #392 you can test it with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323
Problem
When using a MCPAgent locally, the POST
/messagehandler fetches the Durable Object usingidFromName("sse:${sessionId}")but does not re-initialize or update the props context via_init()or similar.This leads to stale or missing values inside
this.props. For instance, in the Auth0 integration example,this.props.tokenSet.accessTokenfromtokenExchangeCallbacknever updates after the first token exchange. Even though the refresh token flow is correctly triggered, the updated access token never reaches the Durable Object instance, breaking authenticated API requests.Solution
Added a call to
await doStub._init(ctx.props)before forwarding the request to the Durable Object in the POST/messagehandler. This ensures that the Durable Object instance has the latest props context, including updated access tokens from OAuth refresh flows.Testing