Skip to content

fix: refresh props for existing Durable Objects via serveSSE POST endpoint#337

Closed
asghar-mir wants to merge 2 commits into
cloudflare:mainfrom
refactco:fix/refresh-props-sse-post-endpoint
Closed

fix: refresh props for existing Durable Objects via serveSSE POST endpoint#337
asghar-mir wants to merge 2 commits into
cloudflare:mainfrom
refactco:fix/refresh-props-sse-post-endpoint

Conversation

@asghar-mir

Copy link
Copy Markdown

Fixes #323

Problem

When using a MCPAgent locally, the POST /message handler fetches the Durable Object using idFromName("sse:${sessionId}") but does not re-initialize or update the props context via _init() or similar.

This leads to stale or missing values inside this.props. For instance, in the Auth0 integration example, this.props.tokenSet.accessToken from tokenExchangeCallback never updates after the first token exchange. Even though the refresh token flow is correctly triggered, the updated access token never reaches the Durable Object instance, breaking authenticated API requests.

Solution

Added a call to await doStub._init(ctx.props) before forwarding the request to the Durable Object in the POST /message handler. This ensures that the Durable Object instance has the latest props context, including updated access tokens from OAuth refresh flows.

Testing

  • All existing tests pass
  • The fix follows the same pattern already used in the GET handler for initial SSE connections
  • No breaking changes to the API

@changeset-bot

changeset-bot Bot commented Jun 26, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a661b48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@threepointone

Copy link
Copy Markdown
Contributor

we landed this one instead, would it work for you? #392 you can test it with npm i agents@beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow refreshing props for existing Durable Objects via serveSSE POST endpoint

2 participants