fix(ai-chat): sync client tools cache on tool result and align wire type#913
Merged
Merged
Conversation
Update _lastClientTools and persist to SQLite when clientTools arrives via CF_AGENT_TOOL_RESULT, so multi-step tool chains and subsequent continuations always use the latest schemas. Previously the incoming tools were passed through but never cached, leaving _lastClientTools stale. Also align the clientTools wire type in types.ts with the canonical ClientToolSchema by using JSONSchema7 for parameters instead of Record<string, unknown>. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 1efe601 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update _lastClientTools and persist to SQLite when clientTools arrives via CF_AGENT_TOOL_RESULT, so multi-step tool chains and subsequent continuations always use the latest schemas. Previously the incoming tools were passed through but never cached, leaving _lastClientTools stale.
Also align the clientTools wire type in types.ts with the canonical ClientToolSchema by using JSONSchema7 for parameters instead of Record<string, unknown>.