fix(ai-chat): ensure jsonSchema initialized before onChatMessage#979
Merged
Conversation
AIChatAgent's onMessage wrapper bypasses the base Agent's wrapper which calls ensureJsonSchema(). This caused "jsonSchema not initialized" errors when getAITools() was called in onChatMessage. Add ensureJsonSchema() call to AIChatAgent's onMessage wrapper to match the base Agent pattern.
🦋 Changeset detectedLatest commit: 14de6a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsonSchema not initializederror when callinggetAITools()inonChatMessageProblem
After PR #565 (RPC transport), the base
Agentclass wrapsonMessageto callensureJsonSchema()before processing messages. However,AIChatAgentre-wrapsonMessagein its constructor and handles chat messages directly without going through the base wrapper.This caused
getAITools()to throw "jsonSchema not initialized" when called inonChatMessage().Fix
Add
await this.mcp.ensureJsonSchema()toAIChatAgent'sonMessagewrapper, matching the pattern used in the baseAgentclass.Test plan
getAITools()inonChatMessage