fix: preserve Anthropic redacted_thinking blocks in message sanitization#980
Merged
Merged
Conversation
Change _sanitizeMessageForPersistence to first strip OpenAI ephemeral fields (e.g., itemId, reasoningEncryptedContent) from all parts, then remove only reasoning parts that are truly empty (no text and no remaining providerMetadata). This preserves Anthropic redacted_thinking blocks (empty text with providerMetadata.anthropic.redactedData) while still filtering out OpenAI placeholder reasoning parts. Adds tests covering preservation of Anthropic redacted_thinking and removal of OpenAI placeholders, and includes a changeset. Fixes #978.
🦋 Changeset detectedLatest commit: 14a93f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_sanitizeMessageForPersistenceinAIChatAgentwas incorrectly stripping Anthropic'sredacted_thinkingblocks. These blocks are stored as reasoning parts with empty text but carry critical data inproviderMetadata.anthropic.redactedData. When stripped, the Anthropic API rejects subsequent requests because the conversation history is incomplete.Fixes #978
Root Cause
The sanitizer filtered out all empty reasoning parts unconditionally. This was designed for OpenAI's ephemeral reasoning placeholders but also caught Anthropic's
redacted_thinkingblocks, which must be preserved for round-tripping.Solution
Refactored
_sanitizeMessageForPersistencefrom a filter-then-strip approach to a strip-then-filter approach:itemId,reasoningEncryptedContent) from all parts firstproviderMetadataThis is provider-agnostic: any provider that stores meaningful data in
providerMetadataon reasoning parts will be preserved automatically. OpenAI placeholders (whose metadata was stripped in step 1) are still correctly removed. Future providers with similar patterns will work without code changes.How providers use
providerMetadataon reasoning parts{ anthropic: { redactedData: "..." } }{ anthropic: { signature: "..." } }{ openai: { itemId: "...", reasoningEncryptedContent: "..." } }Changes
packages/ai-chat/src/index.ts— Reordered sanitization steps + updated JSDocpackages/ai-chat/src/tests/sanitize-messages.test.ts— Added 2 new tests:redacted_thinkingblocks (empty text +providerMetadata.anthropic) are preservedTesting
All 219 tests pass across 24 test files (
npm run test).