Skip to content

Create Blazor how-to - #1022

Merged
kristianfreeman merged 9 commits into
cloudflare:productionfrom
itslevir:production
Jul 19, 2021
Merged

Create Blazor how-to#1022
kristianfreeman merged 9 commits into
cloudflare:productionfrom
itslevir:production

Conversation

@itslevir

@itslevir itslevir commented Mar 29, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@itslevir
itslevir requested a review from a team as a code owner March 29, 2021 01:22
@KimJ15 KimJ15 added this to the Pages and Workers milestone Apr 8, 2021
@KimJ15 KimJ15 added the documentation Documentation edits label Apr 21, 2021
kristianfreeman
kristianfreeman requested changes Jun 30, 2021
View reviewed changes
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md Outdated
@itslevir
itslevir requested a review from a team June 30, 2021 19:15
@itslevir

itslevir commented Jun 30, 2021

Copy link
Copy Markdown
Contributor Author

There are now instructions for creating build.sh. I also added some missing git commands, like git init and git commit

@itslevir
itslevir requested a review from kristianfreeman June 30, 2021 19:34
kristianfreeman
kristianfreeman requested changes Jun 30, 2021
View reviewed changes

@kristianfreeman kristianfreeman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so awesome!! Just a few comments and also - can you move this into the new Framework Guides folder that we've added since you opened this PR? Filename should be products/pages/src/content/framework-guides/deploy-a-blazor-site.md

Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md Outdated
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md
deadlypants1973
deadlypants1973 reviewed Jul 8, 2021
View reviewed changes
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md Outdated
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md Outdated
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md Outdated
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md Outdated
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md Outdated
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md Outdated
@cloudflare cloudflare deleted a comment from kristianfreeman Jul 8, 2021
deadlypants1973
deadlypants1973 reviewed Jul 8, 2021
View reviewed changes
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md Outdated
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md
@deadlypants1973 @kristianfreeman
Apply suggestions from code review
e97401a 
style edits

Co-authored-by: Kristian Freeman <kristian@kristianfreeman.com>
deadlypants1973
deadlypants1973 reviewed Jul 8, 2021
View reviewed changes
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md
deadlypants1973
deadlypants1973 reviewed Jul 8, 2021
View reviewed changes
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md
deadlypants1973
deadlypants1973 reviewed Jul 8, 2021
View reviewed changes
Comment thread products/pages/src/content/how-to/deploy-a-blazor-site.md
deadlypants1973
deadlypants1973 suggested changes Jul 8, 2021
View reviewed changes

@deadlypants1973 deadlypants1973 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to do edits myself in the Github UI but for some reason getting errors. @lerichardson thank you for this! Can you please add the markdown edits and code block backticks in the comments I indicated so we can merge this? :)

@itslevir

itslevir commented Jul 8, 2021

Copy link
Copy Markdown
Contributor Author

Yes. I'll get to this as soon as I can!

@itslevir

itslevir commented Jul 16, 2021

Copy link
Copy Markdown
Contributor Author

I believe I fixed all of the issues, let me know what I missed

@kristianfreeman

kristianfreeman commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

thanks! @lerichardson do you have a repo i can test with?

@itslevir

itslevir commented Jul 19, 2021

Copy link
Copy Markdown
Contributor Author

Yes, just use the repo I forked https://github.com/lerichardson/cloudflare-docs

@kristianfreeman

kristianfreeman commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

Yes, just use the repo I forked https://github.com/lerichardson/cloudflare-docs

ah, i mean a blazor example project :)

@itslevir

itslevir commented Jul 19, 2021

Copy link
Copy Markdown
Contributor Author

Oh! Here: https://github.com/lerichardson/blazor-test

@kristianfreeman
kristianfreeman merged commit 86814d1 into cloudflare:production Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kristianfreeman kristianfreeman kristianfreeman approved these changes
+1 more reviewer
@deadlypants1973 deadlypants1973 deadlypants1973 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@deadlypants1973 deadlypants1973

Labels

documentation Documentation edits product:pages

Projects

None yet

Milestone

Pages and Workers

Development

Successfully merging this pull request may close these issues.

4 participants

@itslevir @kristianfreeman @deadlypants1973 @KimJ15