Content types for stream and byoip - #1303
Merged
Merged
Conversation
kodster28
requested review from
Everlag,
bkrebsbach,
renandincer and
third774
as code owners
May 10, 2021 18:23
bkrebsbach
approved these changes
May 10, 2021
Everlag
suggested changes
May 10, 2021
Contributor
|
Please don't merge the Stream changes until @zaidf takes a look and approves. This is a big change to what people see at the first page of our product docs. |
Everlag
reviewed
May 10, 2021
Collaborator
Author
|
Howdy @Everlag, since it's taken @zaidf a while to respond and our team is trying to get these We can go back and discuss/address that in another PR. |
Everlag
approved these changes
May 20, 2021
Contributor
|
LGTM, thanks for making the changes. Happy to continue discussing the other changes in a separate PR. |
crwaters16
approved these changes
May 20, 2021
crwaters16
left a comment
crwaters16
left a comment
Contributor
There was a problem hiding this comment.
Be sure to comb through and hyphenate the two-word pcx-content-types. A few other nit comments included as well.
This was referenced Jun 24, 2021
This was referenced Jul 5, 2021
This was referenced Jul 19, 2021
This was referenced Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving out SSL b/c it's such a beast...
Added
pcx-content-typemetadata to two doc products. Also fixed broken links + separated out the get started sections from the main page.