Skip to content

Renamed "How To" to "Framework Guides" in Pages doc - #1331

Merged
deadlypants1973 merged 4 commits into
productionfrom
kate/fixesrename
May 26, 2021
Merged

Renamed "How To" to "Framework Guides" in Pages doc#1331
deadlypants1973 merged 4 commits into
productionfrom
kate/fixesrename

Conversation

@deadlypants1973

Copy link
Copy Markdown
Contributor

No description provided.

@rita3ko

rita3ko commented May 12, 2021

Copy link
Copy Markdown
Collaborator

One thing to keep in mind for this one is that we'll need to set up redirects. CC @signalnerve

@deadlypants1973
deadlypants1973 marked this pull request as ready for review May 13, 2021 13:52
@deadlypants1973
deadlypants1973 requested a review from a team May 13, 2021 13:52
@deadlypants1973
deadlypants1973 requested a review from a team as a code owner May 13, 2021 13:52

@crwaters16 crwaters16 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved now that redirects set up in #1344.

@lukeed

lukeed commented May 18, 2021

Copy link
Copy Markdown
Contributor

Maybe should find a new home for products/pages/src/content/framework-guides/npm-private-registry.md? It's the only one that doesn't fit, but got away with it under the "How To" umbrella

@kristianfreeman

Copy link
Copy Markdown
Contributor

Maybe should find a new home for products/pages/src/content/framework-guides/npm-private-registry.md? It's the only one that doesn't fit, but got away with it under the "How To" umbrella

probably can go in platform - /pages/platform/npm-private-registry

@rita3ko

rita3ko commented May 24, 2021

Copy link
Copy Markdown
Collaborator

we could have a "Framwork Guides" section and a "How-to"s section for things like the NPM packages which is not quite a tutorial but has nothing to do with frameworks.
Another example of something that could go there is: "Setting up a www redirect"

@lukeed

lukeed commented May 24, 2021

Copy link
Copy Markdown
Contributor

Both sound good to me 👍

@lukeed
lukeed force-pushed the kate/fixesrename branch from 366c788 to 726d8c8 Compare May 25, 2021 19:01

@lukeed lukeed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to go 💪 Needed to be force pushed because there was some weird detached head stuff going on that @deadlypants1973 and I fixed together

Missing redirects for all framework guide URLs, which will happen later post-deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants