-
Notifications
You must be signed in to change notification settings - Fork 16k
Stream: Start using API Tokens instead of API Keys #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ order: 3 | |
|
|
||
| # Direct creator uploads | ||
|
|
||
| Direct creator uploads allow users to upload videos without API keys. A common place to | ||
| Direct creator uploads allow users to upload videos without API tokens. A common place to | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe this can be more general; ie, 'without API credentials' That way its generic across tokens and keys. |
||
| use Direct creator uploads is on web apps, client side applications, or on mobile apps | ||
| where users upload content directly to Stream. | ||
|
|
||
|
|
@@ -13,8 +13,7 @@ where users upload content directly to Stream. | |
| To give users the ability to directly upload their videos, first generate and | ||
| provide them with a unique one-time upload URL with the following API request. | ||
|
|
||
| To make API requests you will need your [Cloudflare API key](https://www.cloudflare.com/a/account/my-account) | ||
| your email address and your Cloudflare [account ID](https://www.cloudflare.com/a/overview/). | ||
| To make API requests you will need your [Cloudflare API token](https://www.cloudflare.com/a/account/my-account) and your Cloudflare [account ID](https://www.cloudflare.com/a/overview/). | ||
|
|
||
| ### Upload constraints | ||
|
|
||
|
|
@@ -58,8 +57,7 @@ any other additional arbitrary keys for metadata to be stored. | |
|
|
||
| ```bash | ||
| curl -X POST \ | ||
| -H 'X-Auth-Key:$APIKEY' \ | ||
| -H 'X-Auth-Email:$EMAIL' \ | ||
| -H 'Authorization: Bearer $TOKEN' \ | ||
| https://api.cloudflare.com/client/v4/accounts/$ACCOUNT/stream/direct_upload \ | ||
| --data '{ | ||
| "maxDurationSeconds": 3600, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting an API token is not easy
There's no preset for stream yet

So you have to go through this dialog

Which is very complicated.
We should either have at least one token preset or a dedicated docs page for 'Getting an API token'