Add search to Dev Docs home page#1578
Conversation
|
@gganch can you pull this branch down and test locally? |
|
@pedrosousa @jrf0110 I just tested it locally and everything seems to be working perfectly. Love that there is a global search now, pretty cool! But on mobile it is a little hard to know that there is a search option can we put the 'search docs...' or something similar to let users know that you can search?? Pedro would you mind updating the description of this PR to give a little more context what you implemented? |
|
@pedrosousa I think we can iterate and improve the mobile experience as a different PR given all search experiences would need to be updated. |
|
Yes, I agree. |
|
@jrf0110 Since GG is OOO, can you approve this PR? |
jrf0110
left a comment
There was a problem hiding this comment.
Sorry, @pedrosousa - I never submitted this review. I added some comments a while back and just let them sit in pending.
Co-authored-by: John Fawcett <jfawcett@cloudflare.com>
|
it looks pretty good to me! I am trying to approve but I cant it seems like... |
jrf0110
left a comment
There was a problem hiding this comment.
Tested in Chrome, Firefox, and Edge. LGTM



facetFiltersvalue todevelopers.cloudflare.com/docs-config.jsto enable global search.<SiteSearch>component specific fordevelopers.cloudflare.com, very similar to the<DocsSearch>one in the docs engine, with the following differences:useStaticQuerylocally due to a bug that causes issues on relative imports, just like in the<SEO>component fordevelopers.cloudflare.com.<SiteSearch>component fits the top header indevelopers.cloudflare.com. Also, disabled the blur effect in the site header because it interfered with the blur effect in the search results.<SiteSearch>component to the page header.