Call out the need for poster url encoding - #1751
Merged
third774 merged 1 commit intoJul 19, 2021
Merged
Conversation
bkrebsbach
approved these changes
Jul 8, 2021
Everlag
approved these changes
Jul 9, 2021
zaidf
approved these changes
Jul 12, 2021
Contributor
There was a problem hiding this comment.
add type="note" to aside;
consider adding **Note** as title of Aside to make it clear this is a note.
Contributor
There was a problem hiding this comment.
I'm not sure of the meaning of the sentence can be encoded using JavaScript's "encodeURIComponent()" function to. Is there something missing after the to?
Contributor
Author
There was a problem hiding this comment.
to is referring to the encoded URL. The intention of the sentence is to demonstrate an example of how to go from an un-encoded URL to an encoded one.
Contributor
There was a problem hiding this comment.
Got it. Then this makes perfect sense. Thanks!
Contributor
|
Hey @third774, could you take a look at my comments? Thank you! |
third774
force-pushed
the
poster-url-encoding-aside
branch
from
July 19, 2021 17:14
d4e3a37 to
96bbee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @zaidf