Add new page for logging from Workers#2107
Merged
Merged
Conversation
deadlypants1973
suggested changes
Aug 19, 2021
|
|
||
| ## Adding custom logs | ||
|
|
||
| Here is an example of a Worker with a `console.log` inside the request handler. |
Contributor
There was a problem hiding this comment.
Is this sentence saying that if someone runs the below script it will do the action of 'adding a custom log'?
Contributor
Author
There was a problem hiding this comment.
Yes! Maybe change to:
"You can add custom logs to your Worker with console.log. Any console.log's you add will show up in both the dashboard and wrangler tail. Here is an example of a Worker with a custom log inside the request handler."
Or something like that?
deadlypants1973
requested review from
kristianfreeman and
lukeed
and removed request for
kristianfreeman
August 19, 2021 14:26
kristianfreeman
left a comment
kristianfreeman
left a comment
Contributor
There was a problem hiding this comment.
amazing! few things to note but this is definitely on the right track, congrats on (i think?) your first PR!
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com> Co-authored-by: Kristian Freeman <kristian@kristianfreeman.com>
lukeed
reviewed
Aug 19, 2021
Co-authored-by: Luke Edwards <luke.edwards05@gmail.com>
Contributor
Author
|
Incorporated all the changes! |
Electroid
reviewed
Aug 20, 2021
Electroid
left a comment
Electroid
left a comment
Contributor
There was a problem hiding this comment.
Yay, this is awesome! ❤️ I added a few nit suggestions.
Co-authored-by: Ashcon Partovi <ashcon@partovi.net>
Contributor
Author
|
@Electroid love it! updated! |
deadlypants1973
suggested changes
Aug 20, 2021
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
Contributor
Author
|
@deadlypants1973 updated! |
kristianfreeman
approved these changes
Aug 20, 2021
deadlypants1973
approved these changes
Aug 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrangler dev) and Logging from Workers (coverswrangler tail).cc @deadlypants1973 for content review! Would love any advice you have :)