Fix DO docs indentation & code errors#28156
Merged
Merged
Conversation
Co-authored-by: elithrar <elithrar@users.noreply.github.com>
ask-bonk
Bot
requested review from
Oxyjun,
elithrar,
joshthoward,
lambrospetrou,
mikenomitch and
vy-ton
as code owners
February 6, 2026 16:40
elithrar
approved these changes
Feb 6, 2026
elithrar
enabled auto-merge (squash)
February 6, 2026 16:41
elithrar
approved these changes
Feb 6, 2026
elithrar
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - reviewed and the type fixes are valid.
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://2abe8f3e.preview.developers.cloudflare.com Files with changes (up to 15) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tasks are complete. Here's a summary of all changes made to
src/content/docs/durable-objects/best-practices/rules-of-durable-objects.mdx:Indentation fixes (16 code blocks)
Fixed broken indentation in 16 of 29 code examples where code had either:
All 27 occurrences of ```````` were replaced with standard
```closings.Affected code blocks:
Code correctness fixes (2 issues)
locationHintAPI usage (line ~394): MovedlocationHintfromidFromName()toget(), which is the correct API placement per the Cloudflare Workers runtime.alarm()parameter type (line ~1307): Changedasync alarm(alarmInfo)toasync alarm(alarmInfo?: AlarmInvocationInfo)- added the proper type annotation and made the parameter optional to match the base class signature.Closes #28155
github run