Skip to content

DO: document deleteAll() now deletes alarms#28515

Merged
vy-ton merged 7 commits into
productionfrom
delete-all-alarms
Feb 24, 2026
Merged

DO: document deleteAll() now deletes alarms#28515
vy-ton merged 7 commits into
productionfrom
delete-all-alarms

Conversation

@vy-ton

@vy-ton vy-ton commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ product:changelog size/s labels Feb 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR requires additional review attention because it affects the following areas:

Partials

This PR updates partial files, which are pieces of content used across multiple files in our Render component.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/changelog/ @cloudflare/pm-changelogs, @cloudflare/pcx-technical-writing
/src/content/compatibility-flags/ @irvinebroque, @mikenomitch, @GregBrimble, @cloudflare/pcx-technical-writing
/src/content/docs/durable-objects/ @elithrar, @vy-ton, @joshthoward, @oxyjun, @lambrospetrou, @mikenomitch, @cloudflare/pcx-technical-writing
/src/content/partials/durable-objects/ @elithrar, @rita3ko, @irvinebroque, @vy-ton, @cloudflare/pcx-technical-writing

@vy-ton
vy-ton marked this pull request as ready for review February 23, 2026 02:56
@vy-ton
vy-ton requested a review from a team February 23, 2026 02:56
@elithrar

Copy link
Copy Markdown
Collaborator

/bonk perform a thorough review. make suggestions for any fixes.

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the deleteAll() alarm deletion documentation changes. Found a few issues — one likely build-affecting typo, a spelling fix, and a couple of style improvements.

Summary by severity:

  • HIGH (1): Stray git text appended to end of line in partial — likely a copy-paste artifact that will render as visible junk text
  • MEDIUM (2): Typo "compatibiltiy" → "compatibility"; deleteAlarm() missing monospace formatting
  • LOW (2): Changelog title consistency (singular "alarm" vs plural used elsewhere); description could use "Clean up" instead of "Cleanup"

Comment thread src/content/partials/durable-objects/api-storage-other-methods.mdx Outdated
Comment thread src/content/docs/durable-objects/best-practices/rules-of-durable-objects.mdx Outdated
@@ -0,0 +1,23 @@
---
title: deleteAll() now deletes Durable Object alarm

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: the title uses singular "alarm" but the rest of the PR (compatibility flag description, partial) uses plural "alarms". Consider pluralizing for consistency, since a Durable Object can have an active alarm that deleteAll() will delete.

Suggested change
title: deleteAll() now deletes Durable Object alarm
title: deleteAll() now deletes Durable Object alarms

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bonk Changelog should use singular "alarm" everywhere

Comment thread src/content/changelog/durable-objects/2026-02-24-deleteall-deletes-alarms.mdx Outdated
@ask-bonk

ask-bonk Bot commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

@ask-bonk

ask-bonk Bot commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Review posted with 4 suggestions across 3 files. Here is the summary:

Review Summary

HIGH (1):

  • src/content/partials/durable-objects/api-storage-other-methods.mdx:11 — Stray .git text appended to the end of the line about KV-backed deleteAll() failures. This is a copy-paste artifact that will render as visible junk text in the published docs.

MEDIUM (2):

  • src/content/docs/durable-objects/best-practices/rules-of-durable-objects.mdx:1413 — "compatibiltiy" is misspelled (should be "compatibility"), and deleteAlarm() is missing monospace backtick formatting to match other API references on the page.

LOW (2):

  • src/content/changelog/durable-objects/2026-02-24-deleteall-deletes-alarms.mdx:2 — Changelog title uses singular "alarm" but the rest of the PR consistently uses "alarms". Suggested pluralizing for consistency.
  • src/content/changelog/durable-objects/2026-02-24-deleteall-deletes-alarms.mdx:3 — Description says "Cleanup" (noun) but the verb form should be two words: "Clean up".

Overall the content changes are well-structured and technically sound. The compatibility flag file and the partial update correctly document the new behavior with appropriate fallback guidance for older compatibility dates.

github run

vy-ton and others added 4 commits February 23, 2026 10:08
….mdx

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
…le-objects.mdx

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
…etes-alarms.mdx

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
Co-authored-by: vy-ton <vy-ton@users.noreply.github.com>
@ask-bonk

ask-bonk Bot commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Changed "alarms" to "the alarm" on line 19 of the changelog file. The changelog now consistently uses singular "alarm" throughout — matching the title on line 2 ("deletes Durable Object alarm") and the body on line 10 ("deletes a Durable Object alarm").

github run

@vy-ton
vy-ton enabled auto-merge (squash) February 23, 2026 20:38
Comment thread src/content/partials/durable-objects/api-storage-other-methods.mdx Outdated
….mdx

Co-authored-by: Maddy <130055405+Maddy-Cloudflare@users.noreply.github.com>
@vy-ton
vy-ton merged commit 432982a into production Feb 24, 2026
9 checks passed
@vy-ton
vy-ton deleted the delete-all-alarms branch February 24, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:changelog product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants