Skip to content

Adds docs for container rollout none option#28543

Closed
mikenomitch wants to merge 2 commits into
productionfrom
nomitch/container-rollout
Closed

Adds docs for container rollout none option#28543
mikenomitch wants to merge 2 commits into
productionfrom
nomitch/container-rollout

Conversation

@mikenomitch

@mikenomitch mikenomitch commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Added a new option to skip container rollout in Wrangler - cloudflare/workers-sdk#12656 - Adds docs for this.


Open with Devin

@elithrar

Copy link
Copy Markdown
Collaborator

/bonk review and suggest (only) changes in-line

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Review posted. Here's a summary of what I suggested:

Review Summary

The PR correctly documents the new --containers-rollout=none option across three files. The content is accurate and well-structured. I posted 5 inline suggestions:

LOW — Style/wording (all files)

  1. containers/get-started.mdx:26 — Link --containers-rollout=none to the Wrangler deploy command reference so users can discover all rollout options.
  2. containers/get-started.mdx:34 — Minor sentence restructure: "build and push steps, deploying" → "build and push steps and deploys" to avoid a dangling participle.
  3. sandbox/configuration/wrangler.mdx:57 — Same link suggestion as Add robots.txt to test sites #1.
  4. sandbox/configuration/wrangler.mdx:65 — Same wording fix as Updating docs to indicate correct Authorization Header for Signed URL requests #2.
  5. workers/wrangler/commands.mdx:341-343 — Use backticks on the option values (gradual, immediate, none) for consistency with how other flag values are formatted on this page. Also "previous deploy" → "previous deployment" for consistency with the containers/sandbox pages.

No build-breaking or content-correctness issues found. The new section heading levels are correct (H3 under H2), the PackageManagers component is properly imported and used, and the repeated content across containers/sandbox pages is identical (which is fine since they serve different audiences).

github run

@github-actions

Copy link
Copy Markdown
Contributor

Hey there, we've marked this pull request as stale because there's no recent activity on it. This label is helps us identify PRs that might need updates (or to be closed out by our team if no longer relevant).

@github-actions github-actions Bot added the stale label Mar 11, 2026
Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
@mikenomitch
mikenomitch enabled auto-merge (squash) April 6, 2026 20:07

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@emily-shen emily-shen closed this Apr 20, 2026
auto-merge was automatically disabled April 20, 2026 14:05

Pull request was closed

@github-actions
github-actions Bot deleted the nomitch/container-rollout branch June 6, 2026 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants