[Workflows] Update step limits to 25k and add changelog#28563
Merged
Conversation
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
mia303
force-pushed
the
update-workflows-step-limits
branch
from
February 24, 2026 19:35
f0fce67 to
9a82dc1
Compare
Contributor
Collaborator
|
/bonk run a full review, use the changelog skill, and suggest changes in-line |
Contributor
There was a problem hiding this comment.
Thanks for the changelog and limits update! A few suggestions below — mostly minor style items and one content gap.
Summary:
- MEDIUM: Date format in changelog frontmatter is non-standard (
12:00:00 UTCsuffix) - MEDIUM: Config code block should use
WranglerConfigcomponent (or at minimumjsonc) - LOW: Grammar fix on the footnote line you touched
- LOW: Consider adding a "Configuring step limits" subsection to the limits page (similar to the existing CPU and subrequest limit sections)
Contributor
|
Review posted with 4 inline suggestions on the PR. Here's a summary: Review SummaryChangelog entry (
|
| Severity | Issue | Suggestion |
|---|---|---|
| MEDIUM | Date format 2026-02-26 12:00:00 UTC is inconsistent with every other Workflows changelog, which all use plain YYYY-MM-DD |
Change to date: 2026-02-26 |
| MEDIUM | Config example uses a bare ```json fence. Wrangler config should use the WranglerConfig component (renders both TOML and JSON tabs) |
Replace with a WranglerConfig block using TOML input, with an import statement added |
Limits page (limits.mdx)
| Severity | Issue | Suggestion |
|---|---|---|
| LOW | Footnote [^5] reads "step.sleep do not count" — should be "does not" since step.sleep is singular |
Grammar fix inline |
| LOW | Table now says "configurable up to 100,000" but there is no section explaining how to configure it. The CPU and subrequest limits sections both have WranglerConfig examples |
Add a "### Increasing Workflow step limits" subsection documenting the workflows[].limits.steps config key |
What looks good
- Frontmatter fields (
title,description,products) are correct and complete - The limits table update is accurate and covers both Free and Paid tiers
- The changelog body is well-structured: opens with the change, shows config, provides context on the previous limit, and closes with a link to the limits page
- The
"max."abbreviation in the footnote was properly expanded to"maximum"
Contributor
|
The new subsection is added and follows the same pattern as the existing "Increasing Workflow CPU limits" and "Increasing Workflow subrequest limits" sections. It uses |
mia303
force-pushed
the
update-workflows-step-limits
branch
2 times, most recently
from
February 27, 2026 19:57
379aab4 to
0c5f4d1
Compare
aninibread
approved these changes
Mar 2, 2026
jonesphillip
approved these changes
Mar 2, 2026
mia303
force-pushed
the
update-workflows-step-limits
branch
2 times, most recently
from
March 3, 2026 14:25
a61bfa1 to
9c069b0
Compare
mia303
force-pushed
the
update-workflows-step-limits
branch
2 times, most recently
from
March 3, 2026 16:07
655f979 to
c3a5ff5
Compare
whoiskatrin
approved these changes
Mar 3, 2026
mia303
requested review from
a team,
rita3ko,
thomasgauvin and
threepointone
as code owners
March 3, 2026 16:50
mia303
added a commit
that referenced
this pull request
Mar 3, 2026
…)" This reverts commit 7585e1f.
mia303
added a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updating limits page & adding changelog for increased Workflows step limits
Documentation checklist