Privacy proxy updates - #29029
Closed
danish-m-qureshi wants to merge 4 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Privacy Proxy and Privacy Gateway documentation, including new/expanded authentication guidance and a major rewrite of Privacy Gateway metrics reference content.
Changes:
- Updates Privacy Proxy authentication documentation to add mTLS alongside PSK and Privacy Pass.
- Rewrites Privacy Gateway metrics reference to document available GraphQL nodes, fields, and sample queries using
Details. - Removes alternating-row shading CSS for markdown tables.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/styles/table.css | Removes global markdown-table alternating row shading rule. |
| src/content/docs/privacy-proxy/concepts/authentication.mdx | Adds mTLS authentication section and updates the authentication methods table. |
| src/content/docs/privacy-gateway/reference/metrics.mdx | Major expansion/restructure of Privacy Gateway GraphQL metrics documentation and examples. |
Comments suppressed due to low confidence (1)
src/styles/table.css:22
- This change removes the global alternating-row shading rule for markdown tables. Since this affects table readability site-wide (not just Privacy Proxy/Privacy Gateway docs), consider either scoping the style change more narrowly or adding context (for example, a replacement style or rationale) so it’s clear this regression/visual change is intentional.
padding-inline-end: 1rem;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | Pre-shared key (PSK) | Proof of concept, testing | Lower | | ||
| | Privacy Pass tokens | Production deployments | Higher | | ||
| | Privacy Pass tokens | Client to server | High | | ||
| | mTLS | Server to server | Higher | |
Comment on lines
+20
to
+24
| <h2 id="making-a-request">Making a request</h2> | ||
|
|
||
| The following example shows a complete request with authentication headers. Replace `<API_TOKEN>` with your token and update the query body as needed. | ||
|
|
||
| ```bash |
| * Aggregated totals for various metrics, per dimension. | ||
| | Argument | Required | Description | | ||
| | -------- | -------- | ----------- | | ||
| | `filter` | Yes | Filter your data. `accountTag` is always required. | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots (optional)
Documentation checklist