Add Spectrum note for IP access rules - #29644
Merged
Merged
Conversation
Co-authored-by: Oxyjun <Oxyjun@users.noreply.github.com>
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Oxyjun
approved these changes
Apr 7, 2026
Contributor
|
Preview URL: https://96747331.preview.developers.cloudflare.com Files with changes (up to 15) |
marciocloudflare
added a commit
that referenced
this pull request
Apr 8, 2026
The note added in #29644 incorrectly stated that IP Access rules are the only mechanism for HTTP/HTTPS Spectrum apps. Per the Spectrum docs and internal wiki, IP Access rules only work for TCP/UDP Spectrum apps. HTTP/HTTPS Spectrum apps should use custom rules instead. Also restores the custom rules link in the caution block that was accidentally removed.
marciocloudflare
added a commit
that referenced
this pull request
Apr 8, 2026
* [WAF] Fix incorrect Spectrum IP Access rules note The note added in #29644 incorrectly stated that IP Access rules are the only mechanism for HTTP/HTTPS Spectrum apps. Per the Spectrum docs and internal wiki, IP Access rules only work for TCP/UDP Spectrum apps. HTTP/HTTPS Spectrum apps should use custom rules instead. Also restores the custom rules link in the caution block that was accidentally removed. * refined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes have been successfully applied. Here's a summary of what was modified:
Changes Made
File:
src/content/docs/waf/tools/ip-access-rules/create.mdxChange: Added a note about Spectrum applications after the existing tip callout that recommends using custom rules.
Added content:
Why this helps:
Links: Used relative paths (
/spectrum/and/spectrum/reference/configuration-options/#ip-access-rules) following the repository style guide conventions.The file now has 65 lines (up from 61) with the new note properly positioned between the recommendation tip and the dashboard tabs.
Closes #29640
github run