Update recently added compatibility flags - #29683
Conversation
2265df1 to
0ea6cad
Compare
harrishancock
left a comment
harrishancock
left a comment
There was a problem hiding this comment.
Left some nitpicky comments, but I don't think we should block on them -- we should get this merged and followup on anything important.
0ea6cad to
2384294
Compare
|
Let's do the additional runtime API doc updates separately. Will need to collect more information on them |
| disable_flag: "disable_global_performance_classes" | ||
| --- | ||
|
|
||
| When `enable_global_performance_classes` is enabled, the following classes are available on the global scope: `PerformanceEntry`, `PerformanceMark`, `PerformanceMeasure`, `PerformanceResourceTiming`, `PerformanceObserver`, and `PerformanceObserverEntryList`. |
There was a problem hiding this comment.
I don't think we ever changelogged this? Can we?
|
/bonk |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
| disable_flag: "add_nodejs_compat_eol_v23" | ||
| --- | ||
|
|
||
| When `remove_nodejs_compat_eol_v23` is enabled, APIs that reached end-of-life in Node.js 23.x (EOL June 2025) are removed. |
There was a problem hiding this comment.
Node.js 23.x reached EOL in May 2025, not June 2025.
| When `remove_nodejs_compat_eol_v23` is enabled, APIs that reached end-of-life in Node.js 23.x (EOL June 2025) are removed. | |
| When `remove_nodejs_compat_eol_v23` is enabled, APIs that reached end-of-life in Node.js 23.x (EOL May 2025) are removed. |
|
|
||
| When `remove_nodejs_compat_eol_v23` is enabled, APIs that reached end-of-life in Node.js 23.x (EOL June 2025) are removed. | ||
|
|
||
| This flag is automatically enabled when the `remove_nodejs_compat_eol_v24` flag is enabled after 2025-09-01. |
There was a problem hiding this comment.
Copy-paste error: this should reference the parent remove_nodejs_compat_eol flag, not the v24-specific flag.
| This flag is automatically enabled when the `remove_nodejs_compat_eol_v24` flag is enabled after 2025-09-01. | |
| This flag is automatically enabled when the `remove_nodejs_compat_eol` flag is enabled after 2025-09-01. |
|
Submitted a post-merge review on PR #29683. Found 2 issues in
Posted both as inline suggestions in the review: Review link The other 46 new compatibility flag files look correct — frontmatter is valid, links are well-formed, and technical descriptions are accurate. |
6 participants
Adding multiple workerd compat flags