fix: count all types of code blocks for explanations - #29749
Merged
Conversation
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
colbywhite
force-pushed
the
code.blck.count.fix
branch
from
April 10, 2026 18:07
53585d3 to
83311e5
Compare
This makes the build output unnecessarily chatty. Just keep on chugging along.
Contributor
|
Preview URL: https://6b0c3783.preview.developers.cloudflare.com |
mvvmm
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous code block counting logic only accounted for blocks from expressive code. The count would be off for blocks put in via the package manager component or the just natural use of
```.This logic counts instances of
<pre><code>, which results in code fences when converted back into markdown (via Markdown for Agents).All of this means the code block explain button will explain the appropriate code block.