Skip to content

Add Lai Yi Ohlsen as code owner for Radar docs and changelogs#31561

Merged
devandrepascoa merged 1 commit into
productionfrom
apascoa/add-laiyi-changelog-codeowner
Jun 18, 2026
Merged

Add Lai Yi Ohlsen as code owner for Radar docs and changelogs#31561
devandrepascoa merged 1 commit into
productionfrom
apascoa/add-laiyi-changelog-codeowner

Conversation

@devandrepascoa

@devandrepascoa devandrepascoa commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Adds @laiyi-ohlsen (Lai Yi Ohlsen), the new Radar PM, as a code owner for Radar docs and changelogs so she can review, approve, and merge Radar MRs.

@devandrepascoa
devandrepascoa requested review from a team and kodster28 as code owners June 18, 2026 16:22
@devandrepascoa devandrepascoa self-assigned this Jun 18, 2026
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review

✅ No style-guide issues found in commit e11deb0.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/.github/CODEOWNERS @cloudflare/product-owners, @cloudflare/content-engineering, @kodster28

@devandrepascoa
devandrepascoa marked this pull request as draft June 18, 2026 16:27
@ask-bonk

ask-bonk Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

PR Review: #31561 — Add Lai Yi Ohlsen as changelog code owner

Labels

Suggest applying:

  • radar — primary product area affected
  • chore — repository configuration/ownership change
  • changelog — touches changelog ownership

Summary

This PR makes two categories of changes to .github/CODEOWNERS:

  1. General changelog: Adds @laiyi-ohlsen to /src/content/changelog/ (the parent changelog directory).
  2. Radar ownership: Adds @laiyi-ohlsen to existing Radar paths (/src/content/docs/radar/, /src/content/release-notes/radar.yaml) and introduces new ownership entries for previously unowned Radar paths (/src/assets/images/radar/, /src/content/directory/radar.yaml, /src/icons/radar.svg).

Issues Flagged

1. Missing explicit entry for /src/content/changelog/radar/
The repository has a populated src/content/changelog/radar/ directory (26 changelog entries), but there is no CODEOWNERS line for it. Every other product with a changelog subdirectory has an explicit entry (e.g., changelog/dns/, changelog/waf/, changelog/cache/, etc.). Because /src/content/changelog/radar/ is more specific than /src/content/changelog/, it will still inherit the parent owners, but for consistency and clarity, you should add a dedicated entry:

/src/content/changelog/radar/ @cloudflare/pm-changelogs @cdeath @rubenalex @cloudflare/radar @cloudflare/product-owners @laiyi-ohlsen

2. Incorrect owner assigned to /src/assets/images/radar/
The new line assigns @cloudflare/pm-changelogs to /src/assets/images/radar/:

/src/assets/images/radar/ @cloudflare/pm-changelogs @cloudflare/product-owners @laiyi-ohlsen

This is inconsistent. @cloudflare/pm-changelogs is the team that owns the global changelog images (/src/assets/images/changelog/). /src/assets/images/radar/ is general Radar product documentation imagery. Other product image directories are owned by their respective product teams, not the changelog PM team.

Suggested change:

/src/assets/images/radar/ @cdeath @rubenalex @cloudflare/radar @cloudflare/product-owners @laiyi-ohlsen

3. PR title/description does not match the full diff scope
The title and body frame this as only a changelog change, but the diff also:

  • Adds @laiyi-ohlsen to existing Radar docs/release-notes paths
  • Adds three brand-new CODEOWNERS entries for Radar assets (images/radar/, directory/radar.yaml, icons/radar.svg)

If these Radar changes are intentional, the PR description should be updated to mention them. If not, they should be removed to keep the PR focused.

4. Commit message vs. PR title mismatch
The commit says docs: add Lai Yi Ohlsen as Radar code owner, while the PR title says Add Lai Yi Ohlsen as changelog code owner. These should be aligned.

Recommendation

Approve after addressing #1 (missing changelog/radar/ entry) and #2 (pm-changelogs on product images), and updating the PR description to accurately reflect the Radar scope.

github run

@devandrepascoa devandrepascoa changed the title Add Lai Yi Ohlsen as changelog code owner Add Lai Yi Ohlsen as code owner for Radar docs and changelogs Jun 18, 2026
@devandrepascoa
devandrepascoa force-pushed the apascoa/add-laiyi-changelog-codeowner branch from dab4a9f to e11deb0 Compare June 18, 2026 16:45
@devandrepascoa
devandrepascoa marked this pull request as ready for review June 18, 2026 17:07
@devandrepascoa
devandrepascoa merged commit 892d5a1 into production Jun 18, 2026
15 checks passed
@devandrepascoa
devandrepascoa deleted the apascoa/add-laiyi-changelog-codeowner branch June 18, 2026 17:13
@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants