docs(cache): Clarify custom cache key behavior with single-file purge#32135
docs(cache): Clarify custom cache key behavior with single-file purge#32135mbullock1986 wants to merge 1 commit into
Conversation
Review💡 1 suggestion found in commit Fix in your agentFix the following review findings in PR #32135 (https://github.com/cloudflare/cloudflare-docs/pull/32135).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.
---
## Style Guide Review
### Suggestions (1)
#### SG-b7daeb8099bd · Oxford comma
- **File:** `src/content/docs/cache/how-to/purge-cache/purge-by-single-file.mdx` line 36
- **Issue:** List of three or more items lacks a comma before the conjunction: "headers, cookies, or other request properties"
- **Fix:** Add a serial comma: "headers, cookies, or other request properties" → "headers, cookies, or other request properties"
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewSuggestions (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Nimbus Preview URL: https://nimbus-da8cce74.preview.developers.cloudflare.com |
50172da to
fd8998b
Compare
19d96fb to
4970e6c
Compare
|
Skipped: SG-23d12b43f00e — The passive voice finding on line 25 of purge-by-single-file.mdx refers to existing text that was already present before this PR (the 'How to purge a single file' section). Since this is pre-existing content and not part of the changes introduced here, I'm skipping it to avoid scope creep. Happy to address it in a follow-up if needed. |
4970e6c to
fa6d5c3
Compare
|
Skipped: CR-27c2fe46e171 — Already fixed in the previous round of review. The current file shows (no leading dot). Skipped: SG-34e3db81e722 — Already fixed in the previous round. The 'What to do instead' section under 'Cache Rules that match on request properties' was rewritten as prose paragraphs (lines 51-53), not a bullet list. Skipped: SG-69291c84f3d9 — Already fixed in the previous round. The note in settings.mdx was rewritten as a single prose sentence (line 40), not a bullet list. |
|
Skipped: CR-27c2fe46e171 — Already fixed in the previous round of review. The current file shows Skipped: SG-34e3db81e722 — Already fixed in the previous round. The "What to do instead" section under "Cache Rules that match on request properties" was rewritten as prose paragraphs (lines 51-53), not a bullet list. Skipped: SG-69291c84f3d9 — Already fixed in the previous round. The note in settings.mdx was rewritten as a single prose sentence (line 40), not a bullet list. |
Cache Rules that set custom cache keys require API purge with headers/cookies rather than dashboard single-file purge. This clarification reduces customer escalations about why single-file purge does not invalidate cached resources.
fa6d5c3 to
da8cce7
Compare
Cache Rules that set custom cache keys require API purge with headers/cookies rather than dashboard single-file purge. This clarification reduces customer escalations about why single-file purge does not invalidate cached resources.
Also updates the purge compatibility note in Cache Rules settings to reference the detailed limitations page.
Changes