Skip to content

fix: require skip comments before fix commits in agent prompt - #32189

Merged
mvvmm merged 2 commits into
productionfrom
flue/fix-agent-prompt-order
Jul 21, 2026
Merged

fix: require skip comments before fix commits in agent prompt#32189
mvvmm merged 2 commits into
productionfrom
flue/fix-agent-prompt-order

Conversation

@mvvmm

@mvvmm mvvmm commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

The "Fix in your agent" prompt previously said "fix all legitimate findings; post a comment for any you skip" without specifying order. This caused agents to post skip comments after pushing fix commits — but a push immediately triggers a new review, which reads PR comments as part of reconciliation. Skip comments posted after the push are invisible to that review run.

Makes the ordering explicit: post skip comments first, then push fixes.

@mvvmm
mvvmm marked this pull request as ready for review July 20, 2026 22:48
@mvvmm
mvvmm requested review from a team and kodster28 as code owners July 20, 2026 22:48
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review

✅ No issues found in commit 4cf3d23.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

No code review issues found.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@mvvmm
mvvmm merged commit eb21918 into production Jul 21, 2026
15 checks passed
@mvvmm
mvvmm deleted the flue/fix-agent-prompt-order branch July 21, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants