[Artifacts] Fix example formatting and copy#32191
Open
dinasaur404 wants to merge 3 commits into
Open
Conversation
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
dinasaur404
force-pushed
the
artifacts-build-and-deploy-on-push
branch
from
July 20, 2026 22:58
3f44dc5 to
d45b0f2
Compare
dinasaur404
marked this pull request as ready for review
July 20, 2026 23:02
dinasaur404
requested review from
a team,
elithrar,
kodster28,
mattzcarey and
whoiskatrin
as code owners
July 20, 2026 23:02
Contributor
Review
👉 Fix in your agent 👈Fix the following review findings in PR #32191 (https://github.com/cloudflare/cloudflare-docs/pull/32191).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Warnings (1)
#### CR-307051b74a6d · Invalid trigger target field
- **File:** `src/content/docs/artifacts/guides/build-and-deploy-on-push.mdx` line 95
- **Issue:** The note tells users to add `"dispatch_namespace": "<DISPATCH_NAMESPACE>"` to the Workflow trigger target, but no Wrangler trigger target schema in the repository documents a `dispatch_namespace` property. Dispatch namespaces are normally configured via the top-level `dispatch_namespaces` binding or `wrangler deploy --dispatch-namespace`.
- **Fix:** Verify that `dispatch_namespace` is a valid trigger target field for this event type; if not, remove the note or move the instruction to the deployment section using the `wrangler deploy --dispatch-namespace` flag.
---
## Conventions
### Warnings (1)
#### CV-1205a4904617 · Scope accuracy
- **File:** PR-level finding
- **Issue:** A new docs page was added at src/content/docs/artifacts/guides/build-and-deploy-on-push.mdx, but the description only describes fixing formatting and copy in an existing page.
- **Fix:** Mention that the PR adds or re-creates the Artifacts build-and-deploy guide page.
---
## Style Guide Review
### Warnings (1)
#### SG-25d959b0ca78 · WranglerConfig compatibility_date should use \`$today\`
- **File:** `src/content/docs/artifacts/guides/build-and-deploy-on-push.mdx` line 55
- **Issue:** Line adds `\t\"compatibility_date\": \"2026-07-21\",` inside `<WranglerConfig>`
- **Fix:** Use `\`$today\`` so the date is replaced at build time
### Suggestions (3)
#### SG-309cbe8c340b · Avoid `i.e.`
- **File:** `src/content/docs/artifacts/guides/build-and-deploy-on-push.mdx` line 30
- **Issue:** Line adds `(i.e. \`pnpm-lock.yaml\`)`
- **Fix:** Replace `i.e.` with `that is` or restructure
#### SG-bcf7111bfa0b · Bullet list has fewer than three items
- **File:** `src/content/docs/artifacts/guides/build-and-deploy-on-push.mdx` line 106
- **Issue:** The bulleted list starting at line 106 has only two items (Runners and Cache)
- **Fix:** Consider writing as prose instead
#### SG-eece61eaf50b · Avoid `i.e.`
- **File:** `src/content/docs/artifacts/guides/build-and-deploy-on-push.mdx` line 182
- **Issue:** Line adds \`step, i.e. \`workspace.runner(...)\`
- **Fix:** Replace `i.e.` with `that is` or restructure
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (1)
ConventionsWarnings (1)
Style Guide ReviewWarnings (1)
Suggestions (3)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
Nimbus Preview URL: https://nimbus-d45b0f24.preview.developers.cloudflare.com |
Contributor
|
Preview URL: https://3b78f59e.preview.developers.cloudflare.com Files with changes (up to 15) |
mia303
force-pushed
the
artifacts-build-and-deploy-on-push
branch
from
July 22, 2026 17:39
c48b4eb to
3b78f59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes formatting and copy in the Artifacts build and deploy example page. Adds pipeline diagrams.
Documentation checklist