next: cleanup fetch and start#102
Merged
Merged
Conversation
emily-shen
force-pushed
the
emily/fetch-cleanup
branch
from
a633c54 to
93c56a8
Compare
gpanders
reviewed
Oct 16, 2025
gpanders
reviewed
Oct 16, 2025
Comment on lines
+244
to
+245
| /** Whether to enable internet access for the container */ | ||
| enableInternet?: boolean; |
Member
There was a problem hiding this comment.
For optional boolean values like this, can we document what the default is if left undefined?
emily-shen
force-pushed
the
emily/fetch-cleanup
branch
from
c610d03 to
3ad0766
Compare
Collaborator
Author
|
just going to push directly to next for now |
emily-shen
added a commit
that referenced
this pull request
Dec 15, 2025
* consolidate fetch and containerFetch * consolidate start and readiness functions * fixups * more fixups
emily-shen
added a commit
that referenced
this pull request
Dec 15, 2025
* consolidate fetch and containerFetch * consolidate start and readiness functions * fixups * more fixups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 1:
containerFetch and fetch are now just fetch.
not entirely sure how to ban users from overriding fetch. i don't think we can do that in typescript alone.
commit 2:
combine start, startAndWaitForPorts, startContainerIfNotRunning and waitForPorts into one function.
also removes 'requiredPorts' where we check all of these on start up. i don't think we should commit to this - we should make this call a user provided health check hook instead where we ping the container.
i noticed that the error strings we're matching on don't exist in the local implementation - we should either add them in and/or reconsider if there is a more robust way to do this other than string matching
todo: