Merged
Conversation
Contributor
Author
|
This could do with more testing, especially attempting to replicate the original issues with prop updates and component order switching. I'll try and come up with a decent way of replicating them. |
marksteyn
approved these changes
Dec 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rendering multiple
Gateways into the sameGatewayDestinationthe order of the child components isn't enforced, meaning that whenever theGatewayreceives props there's a chance that the component tree will change.We ran into this issue when rendering multiple
cf-uicf-component-modals on the same page, as they each render into the sameGatewayDestination. Whenever props changed, the order of the components would switch, causingReactCSSTransitionGroupflickering andreflosses.