Add LifecycleHandler::pre_new_process#6
Merged
Conversation
cbranch
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My ultimate goal is to persist some state on reloads and graceful shutdown to allow the next generation to use that data. I want to be able to restore this state on reboots and crashes. The actual state is the list of cache keys to prewarm, so it's ok to have it a bit stale. It is not ok to have it empty.
When storing state in a file:
pre_new_process()hook should do the trick.shellflip.Passing the data in
send_to_new_processdoesn't feel right for this, but I might be persuadable. The reason I don't like it is because there would be a split in behavior on startup: