Fix saas-admin-template e2e test timeout in live mode#882
Merged
Conversation
The test was timing out because click() waits for navigation using actionTimeout (5s in live mode), but the /admin page SSR can take longer in CI. Using Promise.all with waitForURL allows navigation to use the longer navigationTimeout (15s) instead.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing live e2e test for
saas-admin-templatethat was causing CI failures on main.Root Cause: The test was using
click()on navigation links, which waits for navigation to complete usingactionTimeout(5 seconds in live mode). The/adminpage SSR can take longer than 5 seconds in the CI environment, causing timeouts.Fix: Wrapped navigation clicks with
Promise.all([page.waitForURL(...), click()])pattern. This separates the click action from the navigation wait, allowing navigation to use the longernavigationTimeout(15 seconds) instead ofactionTimeout(5 seconds).Test
Verified locally against live URL:
Related CI failure: https://github.com/cloudflare/templates/actions/runs/20783982439/job/59688307379