Skip to content

chore(release): keep changelog Contributors in the GitHub Release (h3) - #1760

Merged
james-elicx merged 1 commit into
mainfrom
claude/changelog-contributors-h3
Jun 5, 2026
Merged

chore(release): keep changelog Contributors in the GitHub Release (h3)#1760
james-elicx merged 1 commit into
mainfrom
claude/changelog-contributors-h3

Conversation

@james-elicx

Copy link
Copy Markdown
Member

Follow-up to #1753 — this one fix was pushed after that PR merged, so it didn't land.

Problem

changesets/action builds the GitHub Release body via getChangelogEntry(CHANGELOG.md, version), which slices from the ## <version> heading to the next heading of the same depth. The contributor list was written as ## Contributors (h2) — the same depth as ## 0.1.0 — so it acted as the section boundary and got excluded from the GitHub Release (it stayed in the committed CHANGELOG.md, but the release notes were truncated just before it).

Verified against changesets/action v1.9.0 getChangelogEntry (boundary = next same-depth heading).

Fix

Emit ### Contributors (h3) instead. getChangelogEntry includes deeper headings, so the list now stays inside the extracted release body. The in-file section-boundary logic (/^##\s+\d/) is unchanged.

Testing

  • vp test run scripts/version.test.ts — 9/9 pass (assertions updated to ### Contributors).
  • vp check clean.

🤖 Generated with Claude Code

…he GitHub Release

changesets/action builds the GitHub Release body via getChangelogEntry(), which
slices from the `## <version>` heading to the next *same-depth* (`##`) heading.
A `## Contributors` (h2) was acting as that boundary and getting excluded from
the release notes — present in CHANGELOG.md but dropped from the GitHub Release.
Demote to `### Contributors` (h3) so it stays inside the extracted body. The
in-file boundary logic (/^##\s+\d/) is unaffected.

Follow-up to #1753 (merged before this fix landed).
@james-elicx james-elicx changed the title fix(release): keep changelog Contributors in the GitHub Release (h3) chore(release): keep changelog Contributors in the GitHub Release (h3) Jun 5, 2026
@james-elicx
james-elicx enabled auto-merge (squash) June 5, 2026 13:52
@pkg-pr-new

pkg-pr-new Bot commented Jun 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/vinext@1760

commit: b321ed2

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
workers-cache preview production
web preview production

@james-elicx
james-elicx merged commit d98fc06 into main Jun 5, 2026
39 checks passed
@james-elicx
james-elicx deleted the claude/changelog-contributors-h3 branch June 5, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant