perf(utils): skip path separator replace on POSIX - #1766
Merged
james-elicx merged 1 commit intoJun 5, 2026
Merged
Conversation
commit: |
shulaoda
deleted the
06-05-perf_utils_skip_path_separator_replace_on_posix
branch
June 5, 2026 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an
isWindowsguard tonormalizePathSeparatorsso it returns the input unchanged on POSIX instead of running a regex scan.Motivation
normalizePathSeparatorsis called on hot paths — static file cache lookups, route discovery, and entry-module import generation. On Linux/macOS, backslashes never appear in filesystem paths, so the.replace(/\\/g, "/")always scans the full string and finds nothing. Gating it behindprocess.platform === "win32"makes it a no-op on POSIX while preserving the exact Windows behavior.