fix(image-imports): normalize meta specifier separators on Windows - #1791
Merged
james-elicx merged 1 commit intoJun 6, 2026
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalizePathSeparatorsbefore embedding it in the?vinext-metaimport specifier.image-importstest to assert the forward-slash specifier, using the same helper.Background
The
vinext:image-importstransform rewritesimport hero from './x.png'into a URL import plus a?vinext-metaimport that carries the image dimensions. The meta import embeds the resolved absolute path:On Windows
path.resolveproduces backslashes, so the generated specifier used backslashes — inconsistent with POSIX output and against the ESM convention that module specifiers use forward slashes.Note
This is a consistency/robustness fix, not a crash fix. Verified against a real Vite build: a backslash specifier is passed to
resolveIdunchanged (Vite does not normalize it), and the plugin's slash-agnosticresolveId/loadplus Node'sfs(which accepts forward slashes on Windows) handle it either way. Normalizing keeps generated output identical across platforms and avoids relying on tools tolerating non-standard backslash specifiers.Test plan
pnpm test tests/image-imports.test.ts— 18 pass (6 previously failed on Windows due to the assertion expecting native separators)normalizePathSeparatorsis a no-op on POSIX)