refactor(app-router): build discoverSiblingInterceptingRoutes paths with path.posix - #2306
Merged
Conversation
commit: |
Contributor
Performance benchmarksCompared 0 improved · 1 regressed · 5 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
…inginterceptingroutes_paths_with_path.posix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
discoverSiblingInterceptingRoutes, derive the owner and child directories withpath.posix.*, and document thatappDirand each route'spagePath/routePathmust be forward-slash:routeDir:normalizePathSeparators(path.dirname(filePath))→path.posix.dirname(filePath).childDir:path.join(dir, entry.name)→path.posix.join(dir, entry.name).Why
A route's
pagePath/routePathis now a forward-slash canonical id, andappDiris forward-slash by the route-graph contract. Sopath.posix.dirname(filePath)yields the forward-slash owner directory directly — the oldnormalizePathSeparators(path.dirname(...))only existed becausefilePathused to be native (backslash) on Windows.findOwnerRouteForDircompares in forward-slash space, sorouteDirmust be forward-slash, which it now is without the normalization pass. The marker-scanchildDirswitches topath.posix.joinfor the same reason.How
routeDirusespath.posix.dirname(filePath)(dropsnormalizePathSeparatorsand the now-stale comment).childDirusespath.posix.join(dir, entry.name).appDir/pagePath/routePathmust be forward-slash; owner dirs come frompagePath/routePathmatched againstappDir-relativepath.posix.*paths.Testing
vp check packages/vinext/src/routing/app-route-graph.ts— format, lint, and typecheck clean.path.posix===path). On Windows, given the forward-slashpagePath/routePath/appDir,routeDirandchildDirare identical to the previous normalized results. Behavior-preserving, hencerefactor.