fix(ci): skip create-next-app deploy on forks - #2414
Merged
james-elicx merged 1 commit intoJun 29, 2026
Merged
Conversation
commit: |
Contributor
Performance benchmarksCompared 1 improved · 0 regressed · 5 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2413.
Root cause
create-next-app-cloudflare-deploy.ymlruns onpushtomain, so forkmainbranches run it too. The job deploys a fixed Cloudflare Worker and readsCLOUDFLARE_API_TOKEN/CLOUDFLARE_ACCOUNT_IDfrom repository secrets. In forks those secrets resolve to empty values, so Wrangler fails in the non-interactive deploy step even though the generated project build anddist/server/wrangler.jsonverification already passed.This is not a flaky test. It is a secret-backed deploy job running in a repository context where the required secrets are intentionally unavailable.
Validation
ruby -e 'require "yaml"; YAML.load_file(ARGV.fetch(0)); puts "yaml ok"' .github/workflows/create-next-app-cloudflare-deploy.ymlvp run fmt:check -- .github/workflows/create-next-app-cloudflare-deploy.ymlvp check --fixon staged file and full check