fix(ci): serialize tests sharing Vite optimizer cache - #2874
Merged
Conversation
Member
Author
|
/bigbonk review for issues |
commit: |
Contributor
|
james-elicx
marked this pull request as ready for review
August 10, 2026 22:40
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
james-elicx
marked this pull request as draft
August 10, 2026 22:41
james-elicx
marked this pull request as ready for review
August 10, 2026 22:43
Contributor
|
@james-elicx Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node_modules/.viteoptimizer cacheRoot cause
createIsolatedFixture()gives each temporary project a symlink to the workspacenode_modules. Vite therefore resolves each nominal<fixture>/node_modules/.vitedirectory to the same physical optimizer cache. When these files run in parallel workers, one server can re-optimize that cache while another request is loading it. The captured 500 body was VitethrowOutdatedRequest: “There is a new version of the pre-bundle”.The five moved files all have this exact topology:
sass-tsconfig-paths.test.tshybrid-i18n-api-handoff.test.tsmiddleware-matcher-auth.test.tstsconfig-path-alias-resolution.test.tsoptimize-deps-jsx-in-js.test.tsValidation
vp check vite.config.ts: passedCI=1 vp test run --project unit --shard=1/3: no HTTP 500 or outdated-prebundle error; one unrelated localperformance-trace5-second timeout remained under concurrent machine loadTwo independent reviews reported no actionable findings before this PR was opened.