Move the unenv tests from the preset to wrangler e2e

[vicb]

Move the preset tests from the preset package to wrangler e2e.

This is done to allow removing the dependency from the preset to wrangler so that wrangler can depend on the workspace version of the preset.

The tests now run both locally and in prod.

/cc @petebacondarwin @edmundhung @jamesopstad

---

• Tests
  • Tests included
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: refactoring
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: preset change

[changeset-bot]

🦋 Changeset detected

Latest commit: a1af08d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@cloudflare/vite-plugin	Patch
@cloudflare/unenv-preset	Patch
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main vicb/unenv-tests might be a good starting point.

Notes:

• your PR branch should be named v3-backport-10031
• add the skip-v3-pr label to the current PR to stop this workflow from failing

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10031

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10031

miniflare

npm i https://pkg.pr.new/miniflare@10031

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10031

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10031

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10031

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10031

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10031

wrangler

npm i https://pkg.pr.new/wrangler@10031

commit: a1af08d

[petebacondarwin]

I'd rather we don't mix Worker code and Node.js test in the same tsconfig set up.
The seed-files directory is already the place for this sort of thing.
I think we should have something here more along the lines of this: vicb/unenv-tests...pbd/unenv-tests-alt

[vicb]

@petebacondarwin I have refactored the code to remove changes to the eslint config.

The changes in tsconfig.jsons match what's usually done across the repo: exclude nest folders when they store their own tsconfig.json.

PTAL

[petebacondarwin]

OK let's go with this.
Did you see, by the way, in my side branch, that you can simplify the remote tests quite a lot by using wrangler dev --remote? It saves having to create and delete a Worker in each test.

[vicb]

OK let's go with this.
Did you see, by the way, in my side branch, that you can simplify the remote tests quite a lot by using wrangler dev --remote? It saves having to create and delete a Worker in each test.

No I didn't.
I'll take another look and brings in stuff from there in a follow up PR.

Thanks for the reviews and feedback!