Skip to content

fix: polls miniflare to check browser process - #10041

Merged
petebacondarwin merged 7 commits into
mainfrom
fix-browser-close
Jul 22, 2025
Merged

fix: polls miniflare to check browser process#10041
petebacondarwin merged 7 commits into
mainfrom
fix-browser-close

Conversation

@ruifigueira

Copy link
Copy Markdown
Contributor

Playwright relies on a WebSocket close event that is never triggered in local dev. As a workaround, we poll miniflare to check if the browser is still up and running, otherwise we close the websocket explictly.

Fixes: #9945

  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: New feature

@ruifigueira
ruifigueira requested a review from a team as a code owner July 22, 2025 14:59
@changeset-bot

changeset-bot Bot commented Jul 22, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 982437e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
miniflare Minor
@cloudflare/pages-shared Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jul 22, 2025

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10041

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10041

miniflare

npm i https://pkg.pr.new/miniflare@10041

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10041

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10041

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10041

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10041

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10041

wrangler

npm i https://pkg.pr.new/wrangler@10041

commit: 982437e

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jul 22, 2025
@petebacondarwin
petebacondarwin merged commit 059a39e into main Jul 22, 2025
81 of 88 checks passed
@petebacondarwin
petebacondarwin deleted the fix-browser-close branch July 22, 2025 15:55
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

BUG: browser rendering browser.close() hangs

3 participants