Various fixes/improvements around remote bindings being used as local by dario-piotrowicz · Pull Request #11162 · cloudflare/workers-sdk

dario-piotrowicz · 2025-11-03T16:38:18Z

This PR introduces various fixes/improvements around disabled remote bindings, namely:

updates wrangler dev's --local flag's description to clarify that it disables remote bindings. It also undeprecates it and un-hides it.
it addresses the fact that wrangler dev --local currently prints local bindings (configured with remote: true) as remote
it addresses the fact that some remote bindings, such as AI still worked as remote under wrangler dev --local
ensures that remote: false set in startWorker disables remote bindings
adds a remoteBindings option to getPlatformProxy and also to the vite plugin to disable the remote aspect of remote bindings (aligned with vitest-pool-workers)

Tests
- Tests included
- Tests not necessary because:
Public documentation
- Cloudflare docs PR(s): Add details on how to disable remote binding in wrangler dev, getPlatformProxy and the vite plugin cloudflare-docs#26265
- Documentation not necessary because:
Wrangler V3 Backport
- Wrangler PR:
- Not necessary because: remote bindings are not in v3

…a `wrangler dev --local`

…ommand to clarify that it disables remote bindings, also un-deprecate and un-hide it

changeset-bot · 2025-11-03T16:38:23Z

🦋 Changeset detected

Latest commit: 3db45f9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2025-11-03T16:41:00Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11162

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11162

miniflare

npm i https://pkg.pr.new/miniflare@11162

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11162

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11162

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11162

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11162

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11162

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11162

wrangler

npm i https://pkg.pr.new/wrangler@11162

commit: 3db45f9

… dev` command to clarify that it disables remote bindings, also un-deprecate and un-hide it fix incorrect implementation

… set

…ndingsOnly is set

…emote aspect of remote bindings

penalosa · 2025-11-04T10:25:02Z

I think we should unify flags with the Vitest integration, which AFAIK uses remoteBindings: false to disable remote bindings?

dario-piotrowicz · 2025-11-04T10:31:12Z

I think we should unify flags with the Vitest integration, which AFAIK uses remoteBindings: false to disable remote bindings?

you're right, I thought we completely removed that when we released remote bindings 😕

Ok, thanks 🙂, I can use remoteBindings across the board 👍

Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>

penalosa · 2025-11-05T10:54:15Z

@@ -138,3 +138,24 @@ if (!process.env.CLOUDFLARE_ACCOUNT_ID || !process.env.CLOUDFLARE_API_TOKEN) {
 			});
 		});
 }
+
+describe.only("remote bindings disabled", () => {


sorry, ignore it, I'm just trying to debug a CI windows failure 😓 (before just adding a skipIf(process.platform === 'win32') 😅 )

yeah I ended up just skipping the test on windows: https://github.com/cloudflare/workers-sdk/pull/11162/files#diff-d9b32f69a202cbf69dc77c2777a78758abe37967f4015456c65d005d6117c33dR146-R150

penalosa

Generally looks good, with some nits

Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>

dario-piotrowicz added 3 commits November 3, 2025 16:29

Fix bindings with remote: true being logged as remote when run vi…

a3ed9a7

…a `wrangler dev --local`

remote outdated tsdoc param

efc3494

Update the description of the --local flag for the wrangler dev c…

70383ae

…ommand to clarify that it disables remote bindings, also un-deprecate and un-hide it

workers-devprod added this to workers-sdk Nov 3, 2025

github-project-automation Bot moved this to Untriaged in workers-sdk Nov 3, 2025

dario-piotrowicz added 3 commits November 3, 2025 23:25

fixup! Update the description of the --local flag for the `wrangler…

2230f82

… dev` command to clarify that it disables remote bindings, also un-deprecate and un-hide it fix incorrect implementation

add changeset and disable remote bindings when localBindingsOnly is…

4ebead9

… set

make sure startWorker doesn't connect to remote bindings when localBi…

443b6cb

…ndingsOnly is set

dario-piotrowicz changed the title ~~Minor improvements/fixes for the wrangler dev's --local flag~~ Various fixes/improvements around remote bindings being used as local Nov 4, 2025

add hack not to break wrangler pages dev

07efcac

dario-piotrowicz added the skip-v3-pr label Nov 4, 2025

dario-piotrowicz marked this pull request as ready for review November 4, 2025 09:24

dario-piotrowicz requested a review from a team as a code owner November 4, 2025 09:24

add localBindingsOnly option to getPlatformProxy to disable the r…

ba50b6a

…emote aspect of remote bindings

dario-piotrowicz force-pushed the dario/remote-wrangler-dev--local branch from 160ed68 to ba50b6a Compare November 4, 2025 10:10

penalosa requested changes Nov 4, 2025

View reviewed changes

github-project-automation Bot moved this from Untriaged to In Review in workers-sdk Nov 4, 2025

dario-piotrowicz and others added 8 commits November 4, 2025 11:30

use remoteBindings instead of localBindingsOnly

0fc182b

Apply suggestions from code review

ef2101d

Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>

remove unnecessary timeout

1476462

fix incorrect check in getPlatformProxy

0c14ec8

remove unnecessary function wrapping

bfed066

remove unnecessary function invocation

b9b0e54

remove startDev change

7b9a624

remove unnecessary new remoteBindings option from startWorker

0777e3b

dario-piotrowicz requested a review from penalosa November 4, 2025 13:17

add remoteBindings option to vite plugin

a061a10

dario-piotrowicz requested a review from a team November 4, 2025 16:56

penalosa reviewed Nov 5, 2025

View reviewed changes

Comment thread packages/vite-plugin-cloudflare/src/plugin-config.ts Outdated

penalosa reviewed Nov 5, 2025

View reviewed changes

Comment thread packages/wrangler/src/api/integrations/platform/index.ts Outdated

penalosa reviewed Nov 5, 2025

View reviewed changes

Comment thread packages/wrangler/src/dev.ts Outdated

penalosa approved these changes Nov 5, 2025

View reviewed changes

github-project-automation Bot moved this from In Review to Approved in workers-sdk Nov 5, 2025

dario-piotrowicz force-pushed the dario/remote-wrangler-dev--local branch from 46d6edb to dbdb75a Compare November 5, 2025 10:58

skip e2e vite test on windows

fa36841

dario-piotrowicz force-pushed the dario/remote-wrangler-dev--local branch 2 times, most recently from aae4e2b to fa36841 Compare November 5, 2025 12:22

dario-piotrowicz and others added 3 commits November 5, 2025 12:25

Update packages/wrangler/src/api/integrations/platform/index.ts

cf7cc62

Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>

revert unnecessary spreading

d335b5b

rename remoteBindingsEnabled to remoteBindings

3db45f9

dario-piotrowicz merged commit c3ed531 into main Nov 5, 2025
39 of 40 checks passed

github-project-automation Bot moved this from Approved to Done in workers-sdk Nov 5, 2025

dario-piotrowicz deleted the dario/remote-wrangler-dev--local branch November 5, 2025 14:36

workers-devprod mentioned this pull request Nov 5, 2025

Version Packages #11175

Merged

Uh oh!

Conversation

dario-piotrowicz commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new Bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

penalosa commented Nov 4, 2025

Uh oh!

dario-piotrowicz commented Nov 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

penalosa Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

penalosa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dario-piotrowicz commented Nov 3, 2025 •

edited

Loading

changeset-bot Bot commented Nov 3, 2025 •

edited

Loading

pkg-pr-new Bot commented Nov 3, 2025 •

edited

Loading