Detect non-framework static sites - #11180
Conversation
🦋 Changeset detectedLatest commit: 955c719 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
| outputDir: process.cwd(), | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
I think we are missing a test to make sure that we detect when a fist child dir is actually detected as the outputDir?
There was a problem hiding this comment.
I'm not sure what you mean here—could you expand?
There was a problem hiding this comment.
oh sorry I misread the test below 🤔
I thought it was checking a directory of this shape:
- index.html
- random
- index.html
and making sure that the html from the random dir wasn't being picked up
Sorry my bad 🙂
That being said, maybe the case I just described should also be tested?
e.g.
it("outputDir should prioritize the project directory over its child directories", async () => {
await seed({
"index.html": `<h1>Hello World</h1>`,
"public/index.html": `<h1>Hello World</h1>`,
});
await expect(details.getDetailsForAutoConfig()).resolves.toMatchObject({
outputDir: process.cwd(),
});
});?
|
در تاریخ چهارشنبه, نومبر ۵, ۲۰۲۵، ۹:۱۳ ب.ظ Somhairle MacLeòid <
***@***.***> نوشت:
… Merged #11180 <#11180> into
main.
—
Reply to this email directly, view it on GitHub
<#11180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BSNJN5HKW4H5HVCRKM5S5WT33ISLDAVCNFSM6AAAAACLG3LHRSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQG4ZTKNZRG4YTMMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Fixes https://jira.cfdata.org/browse/DEVX-2266
Support non-framework static sites with autoconfig by looking for a folder that contains an
index.htmlfile, and treating that as the output directory.